Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2570993003: Remove unnecessary third_party links: nss, llvm-build, syzygy (Closed)

Created:
4 years ago by kjellander_webrtc
Modified:
4 years ago
Reviewers:
charujain
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary third_party links: nss, llvm-build, syzygy third_party/nss is no longer used. third_party/llvm-build and third_party/syzygy links are not be needed; these dirs are created during 'gclient runhooks' now that we moved to executing hooks in our own DEPS file instead of the ones in chromium/src/DEPS as per https://codereview.webrtc.org/2524673002 BUG=webrtc:5006 NOTRY=True TESTED=Ran all compile trybots with the --clobber flag. Committed: https://crrev.com/ef753e2e02ca2c706f55023b8d75494e1c8fd85a Cr-Commit-Position: refs/heads/master@{#15621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M setup_links.py View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kjellander_webrtc
You're going to get a lot of minor reviews like this since Edward and Patrik ...
4 years ago (2016-12-14 14:46:54 UTC) #6
charujain
lgtm
4 years ago (2016-12-14 14:51:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2570993003/1
4 years ago (2016-12-15 07:44:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 07:48:20 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 07:48:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef753e2e02ca2c706f55023b8d75494e1c8fd85a
Cr-Commit-Position: refs/heads/master@{#15621}

Powered by Google App Engine
This is Rietveld 408576698