DEPS: Specify WebRTC hooks and add a few dependencies

DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741
TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is downloaded without any license prompt.
NOTRY=True

Committed: https://crrev.com/24d812ddc15c0a6ad26375a2522892214d11947b
Cr-Commit-Position: refs/heads/master@{#15195}

[kjellander_webrtc, 2016-11-22 07:06:28]

Description was changed from

==========
DEPS: Specify WebRTC hooks and add a few depdendencies

This removes the need of executing Chromium's runhooks.
For convenience, espresso and javax_inject are added for
Android since this is about to be done soon anyway.

New dependencies:
third_party/espresso
third_party/javax_inject
tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741
==========

to

==========
DEPS: Specify WebRTC hooks and add a few depdendencies

This removes the need of executing Chromium's runhooks.
For convenience, espresso and javax_inject are added for
Android since this is about to be done soon anyway.

New dependencies:
third_party/espresso
third_party/javax_inject
tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without client prompt.
==========

[kjellander_webrtc, 2016-11-22 07:07:25]

Description was changed from

==========
DEPS: Specify WebRTC hooks and add a few depdendencies

This removes the need of executing Chromium's runhooks.
For convenience, espresso and javax_inject are added for
Android since this is about to be done soon anyway.

New dependencies:
third_party/espresso
third_party/javax_inject
tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without client prompt.
==========

to

==========
DEPS: Specify WebRTC hooks and add a few depdendencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without client prompt.
==========

[kjellander_webrtc, 2016-11-22 08:04:17]

Description was changed from

==========
DEPS: Specify WebRTC hooks and add a few depdendencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without client prompt.
==========

to

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without client prompt.
==========

[kjellander_webrtc, 2016-11-22 08:05:47]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-11-22 08:12:13]

Patchset #1 (id:20001) has been deleted

[kjellander_webrtc, 2016-11-22 08:12:18]

Patchset #1 (id:40001) has been deleted

[kjellander_webrtc, 2016-11-22 08:25:00]

Description was changed from

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without client prompt.
==========

to

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without any license prompt.
==========

[kjellander_webrtc, 2016-11-22 08:25:14]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org, phoglund@webrtc.org

[kjellander_webrtc, 2016-11-22 08:27:59]

Edward, this contributes to your work on
https://bugs.chromium.org/p/webrtc/issues/detail?id=5006 in a nice way - the
hooks part is already done with this!

[phoglund, 2016-11-22 08:51:06]

https://codereview.webrtc.org/2524673002/diff/80001/DEPS
File DEPS (left):

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#oldcode29
DEPS:29: 'name': 'check_root_dir_name',
So this isn't needed anymore, why?

https://codereview.webrtc.org/2524673002/diff/80001/DEPS
File DEPS (right):

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#newcode61
DEPS:61: 'name': 'intellij',
Why are these things added, and will we have to maintain parity with chromium
deps now? If they're copied from somewhere, say from where in a comment.

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#newcode359
DEPS:359: # GYP_DEFINES.
Well, not GYP_DEFINES right?

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#newcode386
DEPS:386: # buildtools provides clang_format, libc++, and libc++abi
Nit: end with .

[kjellander_webrtc, 2016-11-22 12:26:30]

PTAL

https://codereview.webrtc.org/2524673002/diff/80001/DEPS
File DEPS (left):

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#oldcode29
DEPS:29: 'name': 'check_root_dir_name',
On 2016/11/22 08:51:06, phoglund wrote:
> So this isn't needed anymore, why?

I was tempted to remove it since it's very old. I better do in a separate CL so
I restored it in PS#3.

https://codereview.webrtc.org/2524673002/diff/80001/DEPS
File DEPS (right):

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#newcode61
DEPS:61: 'name': 'intellij',
On 2016/11/22 08:51:06, phoglund wrote:
> Why are these things added, and will we have to maintain parity with chromium
> deps now? If they're copied from somewhere, say from where in a comment.

They're from the Chromium DEPS file, since we no longer execute the runhooks in
sync_chromium.py.
Added comment.

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#newcode359
DEPS:359: # GYP_DEFINES.
On 2016/11/22 08:51:06, phoglund wrote:
> Well, not GYP_DEFINES right?

Yes, this is still true actually. See
https://cs.chromium.org/chromium/src/third_party/instrumented_libraries/scrip...
(GYP_DEFINES are set on the bots for that particular reason). It's a bit
surprising Chromium still hasn't cleaned that up.
I added a comment about this.

https://codereview.webrtc.org/2524673002/diff/80001/DEPS#newcode386
DEPS:386: # buildtools provides clang_format, libc++, and libc++abi
On 2016/11/22 08:51:06, phoglund wrote:
> Nit: end with .

Purely copied code, but I addressed your comment.

[phoglund, 2016-11-22 13:20:10]

okiedokie. lgtm

[ehmaldonado_webrtc, 2016-11-22 14:54:31]

lgtm

[kjellander_webrtc, 2016-11-22 14:58:19]

Description was changed from

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without any license prompt.
==========

to

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without any license prompt.
NOTRY=True
==========

[kjellander_webrtc, 2016-11-22 14:59:57]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-11-22 14:59:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-22 15:02:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479826797107720,
"parent_rev": "636a17290081e71c17f4ea791daf745802d32f93", "commit_rev":
"10880b3d0c47629c0459ccfd986fd4168da186ca"}

[commit-bot: I haz the power, 2016-11-22 15:02:14]

Description was changed from

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without any license prompt.
NOTRY=True
==========

to

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without any license prompt.
NOTRY=True
==========

[commit-bot: I haz the power, 2016-11-22 15:02:15]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-11-22 15:02:19]

Description was changed from

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without any license prompt.
NOTRY=True
==========

to

==========
DEPS: Specify WebRTC hooks and add a few dependencies

This removes the need of executing Chromium's runhooks.
A selection of hooks (not all) were picked that should be
sufficient for WebRTC's needs.

New dependencies:
* third_party/espresso
* third_party/javax_inject
* tools/clang_format_merge_driver

BUG=webrtc:5578, webrtc:5006, webrtc:6741

TESTED=
rm -rf third_party/android_tools/sdk/extras/google/m2repository/
gclient runhooks
Verified that third_party/android_tools/sdk/extras/google/m2repository/ is
downloaded without any license prompt.
NOTRY=True

Committed: https://crrev.com/24d812ddc15c0a6ad26375a2522892214d11947b
Cr-Commit-Position: refs/heads/master@{#15195}
==========

[commit-bot: I haz the power, 2016-11-22 15:02:22]

Patchset 3 (id:??) landed as
https://crrev.com/24d812ddc15c0a6ad26375a2522892214d11947b
Cr-Commit-Position: refs/heads/master@{#15195}