Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2559953002: Log audio network adapter decisions in event log. (Closed)
Patch Set: Response to comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.h
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.h b/webrtc/logging/rtc_event_log/rtc_event_log.h
index ec57b8b394f45e1d9c719be1a78dc4738ee0e42b..a2f62fa34c216e48dd29c646fed573c56ecce346 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.h
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.h
@@ -108,6 +108,15 @@ class RtcEventLog {
uint8_t fraction_loss,
int32_t total_packets) = 0;
+ // Logs audio network adapror decisions.
+ virtual void LogAnaDecisionEvent(
+ rtc::Optional<int> bitrate_bps,
+ rtc::Optional<int> frame_length_ms,
+ rtc::Optional<float> uplink_packet_loss_fraction,
+ rtc::Optional<bool> enable_fec,
+ rtc::Optional<bool> enable_dtx,
+ rtc::Optional<size_t> num_channels) = 0;
+
// Reads an RtcEventLog file and returns true when reading was successful.
// The result is stored in the given EventStream object.
// The order of the events in the EventStream is implementation defined.
@@ -149,6 +158,12 @@ class RtcEventLogNullImpl final : public RtcEventLog {
void LogBwePacketLossEvent(int32_t bitrate,
uint8_t fraction_loss,
int32_t total_packets) override {}
+ void LogAnaDecisionEvent(rtc::Optional<int> bitrate_bps,
+ rtc::Optional<int> frame_length_ms,
+ rtc::Optional<float> uplink_packet_loss_fraction,
+ rtc::Optional<bool> enable_fec,
+ rtc::Optional<bool> enable_dtx,
+ rtc::Optional<size_t> num_channels) override{};
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698