Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: webrtc/logging/rtc_event_log/rtc_event_log.h

Issue 2559953002: Log audio network adapter decisions in event log. (Closed)
Patch Set: Response to comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 size_t length) = 0; 101 size_t length) = 0;
102 102
103 // Logs an audio playout event. 103 // Logs an audio playout event.
104 virtual void LogAudioPlayout(uint32_t ssrc) = 0; 104 virtual void LogAudioPlayout(uint32_t ssrc) = 0;
105 105
106 // Logs a bitrate update from the bandwidth estimator based on packet loss. 106 // Logs a bitrate update from the bandwidth estimator based on packet loss.
107 virtual void LogBwePacketLossEvent(int32_t bitrate, 107 virtual void LogBwePacketLossEvent(int32_t bitrate,
108 uint8_t fraction_loss, 108 uint8_t fraction_loss,
109 int32_t total_packets) = 0; 109 int32_t total_packets) = 0;
110 110
111 // Logs audio network adapror decisions.
112 virtual void LogAnaDecisionEvent(
113 rtc::Optional<int> bitrate_bps,
114 rtc::Optional<int> frame_length_ms,
115 rtc::Optional<float> uplink_packet_loss_fraction,
116 rtc::Optional<bool> enable_fec,
117 rtc::Optional<bool> enable_dtx,
118 rtc::Optional<size_t> num_channels) = 0;
119
111 // Reads an RtcEventLog file and returns true when reading was successful. 120 // Reads an RtcEventLog file and returns true when reading was successful.
112 // The result is stored in the given EventStream object. 121 // The result is stored in the given EventStream object.
113 // The order of the events in the EventStream is implementation defined. 122 // The order of the events in the EventStream is implementation defined.
114 // The current implementation writes a LOG_START event, then the old 123 // The current implementation writes a LOG_START event, then the old
115 // configurations, then the remaining events in timestamp order and finally 124 // configurations, then the remaining events in timestamp order and finally
116 // a LOG_END event. However, this might change without further notice. 125 // a LOG_END event. However, this might change without further notice.
117 // TODO(terelius): Change result type to a vector? 126 // TODO(terelius): Change result type to a vector?
118 static bool ParseRtcEventLog(const std::string& file_name, 127 static bool ParseRtcEventLog(const std::string& file_name,
119 rtclog::EventStream* result); 128 rtclog::EventStream* result);
120 }; 129 };
(...skipping 21 matching lines...) Expand all
142 const uint8_t* header, 151 const uint8_t* header,
143 size_t packet_length) override {} 152 size_t packet_length) override {}
144 void LogRtcpPacket(PacketDirection direction, 153 void LogRtcpPacket(PacketDirection direction,
145 MediaType media_type, 154 MediaType media_type,
146 const uint8_t* packet, 155 const uint8_t* packet,
147 size_t length) override {} 156 size_t length) override {}
148 void LogAudioPlayout(uint32_t ssrc) override {} 157 void LogAudioPlayout(uint32_t ssrc) override {}
149 void LogBwePacketLossEvent(int32_t bitrate, 158 void LogBwePacketLossEvent(int32_t bitrate,
150 uint8_t fraction_loss, 159 uint8_t fraction_loss,
151 int32_t total_packets) override {} 160 int32_t total_packets) override {}
161 void LogAnaDecisionEvent(rtc::Optional<int> bitrate_bps,
162 rtc::Optional<int> frame_length_ms,
163 rtc::Optional<float> uplink_packet_loss_fraction,
164 rtc::Optional<bool> enable_fec,
165 rtc::Optional<bool> enable_dtx,
166 rtc::Optional<size_t> num_channels) override{};
152 }; 167 };
153 168
154 } // namespace webrtc 169 } // namespace webrtc
155 170
156 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_ 171 #endif // WEBRTC_LOGGING_RTC_EVENT_LOG_RTC_EVENT_LOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698