Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h

Issue 2559953002: Log audio network adapter decisions in event log. (Closed)
Patch Set: Response to comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h
diff --git a/webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h b/webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h
index 315967b8c0a7c30f31fc9d710bdf12751e0e53d8..c461db23a37a62650a7ae044260acb4dd97952e4 100644
--- a/webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h
+++ b/webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h
@@ -58,6 +58,13 @@ class MockRtcEventLog : public RtcEventLog {
void(int32_t bitrate,
uint8_t fraction_loss,
int32_t total_packets));
+ MOCK_METHOD6(LogAnaDecisionEvent,
the sun 2016/12/13 16:31:18 So basically, this function is here to log 6 diffe
michaelt 2016/12/14 14:41:37 Would you prefer to log each event separated. I im
minyue-webrtc 2016/12/16 13:50:31 No, I don't agree. if you pass the proto event as
michaelt 2016/12/20 09:29:55 After a offline discussion, minyue and me agreed o
+ void(rtc::Optional<int> bitrate_bps,
+ rtc::Optional<int> frame_length_ms,
+ rtc::Optional<float> uplink_packet_loss_fraction,
+ rtc::Optional<bool> enable_fec,
+ rtc::Optional<bool> enable_dtx,
+ rtc::Optional<size_t> num_channels));
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698