RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector.

RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector
and requestsSent is updated.

Before:
  requestsSent = total ping requests
Now
  requestsSent = pings sent before first response
  consentRequestsSent = pings after first response

Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentrequestssent

BUG=chromium:633550
Committed: https://crrev.com/e448dd53554b4ecd3dd62a46a08b25044bc2e210
Cr-Commit-Position: refs/heads/master@{#15541}

[hbos, 2016-12-08 15:04:15]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 15:04:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-12-08 15:05:04]

hbos@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, hta@webrtc.org

[hbos, 2016-12-08 15:05:05]

Please take a look, deadbeef and hta.

https://codereview.webrtc.org/2558293002/diff/1/webrtc/api/rtcstatscollector.cc
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2558293002/diff/1/webrtc/api/rtcstatscollector....
webrtc/api/rtcstatscollector.cc:644:
info.sent_ping_requests_before_first_response);
This is the same value that is used by the old getStats for
googCandidatePair.consentRequestsSent.

[commit-bot: I haz the power, 2016-12-08 16:06:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:06:47]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2016-12-08 22:01:30]

https://codereview.webrtc.org/2558293002/diff/1/webrtc/api/rtcstatscollector.cc
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2558293002/diff/1/webrtc/api/rtcstatscollector....
webrtc/api/rtcstatscollector.cc:644:
info.sent_ping_requests_before_first_response);
On 2016/12/08 15:05:05, hbos wrote:
> This is the same value that is used by the old getStats for
> googCandidatePair.consentRequestsSent.

I think the old implementation is incorrect. If anything, consent requests are
sent after connectivity checks. So "requests_sent" should equal
"sent_ping_requests_before_first_response", and "consent_requests_sent" should
equal "sent_ping_requests_total - sent_ping_requests_before_first_response"...
If my assumptions are correct.

Harald?

[hta-webrtc, 2016-12-09 09:58:25]

It's confusing, but consent requests are sent to check that the other party
hasn't closed the connection, while connectivity check requests are sent at
startup to see if we can communicate at all.

Better text in the spec needed.

https://codereview.webrtc.org/2558293002/diff/1/webrtc/api/rtcstatscollector.cc
File webrtc/api/rtcstatscollector.cc (right):

https://codereview.webrtc.org/2558293002/diff/1/webrtc/api/rtcstatscollector....
webrtc/api/rtcstatscollector.cc:644:
info.sent_ping_requests_before_first_response);
On 2016/12/08 22:01:30, Taylor Brandstetter wrote:
> On 2016/12/08 15:05:05, hbos wrote:
> > This is the same value that is used by the old getStats for
> > googCandidatePair.consentRequestsSent.
> 
> I think the old implementation is incorrect. If anything, consent requests are
> sent after connectivity checks. So "requests_sent" should equal
> "sent_ping_requests_before_first_response", and "consent_requests_sent" should
> equal "sent_ping_requests_total - sent_ping_requests_before_first_response"...
> If my assumptions are correct.
> 
> Harald?

Agreed. The defs in
http://rawgit.com/w3c/webrtc-stats/master/webrtc-stats.html#dom-rtcicecandida...
aren't very verbose (I'll get on Bernard's case about that), but they indicate
that requests are partitioned into connectivity requests (before first response)
and consent requests (after first response). Seems worthwhile to expand this CL
to generate both of those based on sent_ping_requests_before_first_response and
sent_ping_requests_total - the code is easier to read if both are present.

[hbos, 2016-12-09 12:54:13]

Description was changed from

==========
RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector.

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentreque...

BUG=chromium:633550
==========

to

==========
RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector
and requestsSent is updated.

Before:
  requestsSent = total ping requests
Now
  requestsSent = pings sent before first response
  consentRequestsSent = pings after first response

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentreque...

BUG=chromium:633550
==========

[hbos, 2016-12-09 12:54:51]

The CQ bit was checked by hbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 12:54:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-12-09 12:55:12]

PTAL hta and deadbeef.

[commit-bot: I haz the power, 2016-12-09 13:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 13:36:15]

Dry run: This issue passed the CQ dry run.

[hta-webrtc, 2016-12-09 13:40:12]

lgtm

[Taylor, 2016-12-09 19:20:53]

deadbeef@google.com changed reviewers:
+ deadbeef@google.com

[Taylor, 2016-12-09 19:20:54]

lgtm

[hbos, 2016-12-12 08:56:18]

The CQ bit was checked by hbos@webrtc.org

[commit-bot: I haz the power, 2016-12-12 08:56:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-12 09:22:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481532978768750,
"parent_rev": "b7ee38d2c24aae135ebbae5641d743e44aaf5a4f", "commit_rev":
"711d4ca1f0057451a7ea1577e0656efb227735d0"}

[commit-bot: I haz the power, 2016-12-12 09:22:56]

Description was changed from

==========
RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector
and requestsSent is updated.

Before:
  requestsSent = total ping requests
Now
  requestsSent = pings sent before first response
  consentRequestsSent = pings after first response

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentreque...

BUG=chromium:633550
==========

to

==========
RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector
and requestsSent is updated.

Before:
  requestsSent = total ping requests
Now
  requestsSent = pings sent before first response
  consentRequestsSent = pings after first response

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentreque...

BUG=chromium:633550

Review-Url: https://codereview.webrtc.org/2558293002
==========

[commit-bot: I haz the power, 2016-12-12 09:22:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 09:23:07]

Description was changed from

==========
RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector
and requestsSent is updated.

Before:
  requestsSent = total ping requests
Now
  requestsSent = pings sent before first response
  consentRequestsSent = pings after first response

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentreque...

BUG=chromium:633550

Review-Url: https://codereview.webrtc.org/2558293002
==========

to

==========
RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector
and requestsSent is updated.

Before:
  requestsSent = total ping requests
Now
  requestsSent = pings sent before first response
  consentRequestsSent = pings after first response

Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-consentreque...

BUG=chromium:633550

Committed: https://crrev.com/e448dd53554b4ecd3dd62a46a08b25044bc2e210
Cr-Commit-Position: refs/heads/master@{#15541}
==========

[commit-bot: I haz the power, 2016-12-12 09:23:07]

Patchset 3 (id:??) landed as
https://crrev.com/e448dd53554b4ecd3dd62a46a08b25044bc2e210
Cr-Commit-Position: refs/heads/master@{#15541}