webrtc/api/rtcstatscollector_unittest.cc - Issue 2558293002: RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/rtcstatscollector_unittest.cc

Issue 2558293002: RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector. (Closed)

Patch Set: requestsSent = pings before first response, consentRequestsSent = pings after first response Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/rtcstatscollector_unittest.cc

diff --git a/webrtc/api/rtcstatscollector_unittest.cc b/webrtc/api/rtcstatscollector_unittest.cc

index 2d2059b93ef22c2dac8f52cfdb4dabd679767099..b973044c94751582d187dbc112f02703b1ff06c8 100644

--- a/webrtc/api/rtcstatscollector_unittest.cc

+++ b/webrtc/api/rtcstatscollector_unittest.cc

@@ -1006,7 +1006,8 @@ TEST_F(RTCStatsCollectorTest, CollectRTCIceCandidatePairStats) {

connection_info.recv_total_bytes = 1234;

connection_info.rtt = 1337;

connection_info.recv_ping_requests = 2020;

- connection_info.sent_ping_requests_total = 1010;

+ connection_info.sent_ping_requests_total = 2020;

+ connection_info.sent_ping_requests_before_first_response = 2000;

connection_info.recv_ping_responses = 4321;

connection_info.sent_ping_responses = 1000;

@@ -1041,9 +1042,10 @@ TEST_F(RTCStatsCollectorTest, CollectRTCIceCandidatePairStats) {

expected_pair.bytes_received = 1234;

expected_pair.current_rtt = 1.337;

expected_pair.requests_received = 2020;

- expected_pair.requests_sent = 1010;

+ expected_pair.requests_sent = 2000;

expected_pair.responses_received = 4321;

expected_pair.responses_sent = 1000;

+ expected_pair.consent_requests_sent = (2020 - 2000);

EXPECT_TRUE(report->Get(expected_pair.id()));

EXPECT_EQ(

« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | webrtc/api/stats/rtcstats_objects.h » ('j') | no next file with comments »