Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2553583002: Delete voice_engine_configurations.h (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, Andrew MacDonald, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete voice_engine_configurations.h The file was aldready pruned down to the point where it only included webrtc/typedefs.h. Therefore, all includes of voice_engine_configurations.h are replaced with typedefs.h, except on two occasions where it was obvously not needed. BUG=webrtc:6506 Committed: https://crrev.com/a9a6d4bc2c31f08a27f2b141b4fc1acd5bf591fa Cr-Commit-Position: refs/heads/master@{#15547}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_codec_database.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_common_defs.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/codec_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/APITest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/RTPFile.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestAllCodecs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestRedFec.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestStereo.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TestVADDTX.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/TwoWayCommunication.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/delay_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/opus_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_defines.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_utility.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/include/file_player.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/include/file_recorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/source/file_player.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/source/file_recorder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_common.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_defines.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/voice_engine_configurations.h View 1 chunk +0 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (14 generated)
hlundin-webrtc
Henrik A: PTAL at this last CL for removing voice_engine_configurations.h Thanks!
4 years ago (2016-12-05 11:22:23 UTC) #3
henrika_webrtc
Thanks. Did not check every file here. LGTM
4 years ago (2016-12-05 11:25:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2553583002/1
4 years ago (2016-12-12 09:52:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/121050)
4 years ago (2016-12-12 09:55:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2553583002/1
4 years ago (2016-12-12 10:26:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/121060)
4 years ago (2016-12-12 10:29:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2553583002/20001
4 years ago (2016-12-12 11:53:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/121079)
4 years ago (2016-12-12 11:56:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2553583002/20001
4 years ago (2016-12-12 13:00:55 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 13:03:07 UTC) #23
commit-bot: I haz the power
4 years ago (2016-12-12 13:03:16 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9a6d4bc2c31f08a27f2b141b4fc1acd5bf591fa
Cr-Commit-Position: refs/heads/master@{#15547}

Powered by Google App Engine
This is Rietveld 408576698