Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2544123003: Move WEBRTC_VOICE_ENGINE_TYPING_DETECTION to transmit_mixer.h (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, qiang.lu, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move WEBRTC_VOICE_ENGINE_TYPING_DETECTION to transmit_mixer.h BUG=webrtc:6506 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device;master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng Committed: https://crrev.com/f00082da37e2118784054c0a2823aac81e517a24 Cr-Commit-Position: refs/heads/master@{#15414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M webrtc/voice_engine/transmit_mixer.h View 4 chunks +9 lines, -3 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/voice_engine_configurations.h View 1 chunk +0 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
hlundin-webrtc
PTAL
4 years ago (2016-12-02 11:45:17 UTC) #2
henrika_webrtc
LGTM
4 years ago (2016-12-02 11:48:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2544123003/1
4 years ago (2016-12-05 09:26:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 10:22:16 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-05 10:22:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f00082da37e2118784054c0a2823aac81e517a24
Cr-Commit-Position: refs/heads/master@{#15414}

Powered by Google App Engine
This is Rietveld 408576698