Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2549443002: Remove API-related #defines from voice_engine_configurations.h (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, qiang.lu, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove API-related #defines from voice_engine_configurations.h BUG=webrtc:6506 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.chromium.mac:mac_chromium_rel_ng,ios-device;master.tryserver.chromium.win:win_chromium_rel_ng;master.tryserver.chromium.android:android_compile_dbg,linux_android_rel_ng Committed: https://crrev.com/e066b302ab18c2b4a9545b1fb907b9d65c72a4b8 Cr-Commit-Position: refs/heads/master@{#15379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -335 lines) Patch
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 4 chunks +0 lines, -62 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 2 chunks +0 lines, -58 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voe_external_media_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voe_file_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voe_hardware_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voe_neteq_stats_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voe_rtp_rtcp_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voe_video_sync_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voe_volume_control_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 2 chunks +1 line, -84 lines 0 comments Download
M webrtc/voice_engine_configurations.h View 1 chunk +0 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
hlundin-webrtc
henrika@, please, take a look. Thanks!
4 years ago (2016-12-01 12:07:28 UTC) #2
henrika_webrtc
Me like ;-) LGTM.
4 years ago (2016-12-01 12:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2549443002/1
4 years ago (2016-12-02 09:40:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/15555)
4 years ago (2016-12-02 09:57:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2549443002/1
4 years ago (2016-12-02 10:26:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 10:30:19 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 10:30:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e066b302ab18c2b4a9545b1fb907b9d65c72a4b8
Cr-Commit-Position: refs/heads/master@{#15379}

Powered by Google App Engine
This is Rietveld 408576698