|
|
DescriptionFix header guard in thread_annotations.h.
It was using a non-WebRTC-named header guard, which could conflict with
other similarly named/intended headers.
BUG=None
NO_DEPENDENCY_CHECKS=true
Committed: https://crrev.com/580df537ce829818448f0563c8aded6fc63b886b
Cr-Commit-Position: refs/heads/master@{#15554}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 20 (12 generated)
The CQ bit was checked by noahric@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
noahric@chromium.org changed reviewers: + mflodman@webrtc.org, tommi@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I'm not sure if this is enough; it may also be a good idea to make these RTC_* macros at the same time, or else a header file with the same guard (today) that has the same macros will now conflict. Anyways, let me know what you guys think.
The CQ bit was checked by tommi@webrtc.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2544003005 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Fix header guard in thread_annotations.h. It was using a non-WebRTC-named header guard, which could conflict with other similarly named/intended headers. BUG=None ========== to ========== Fix header guard in thread_annotations.h. It was using a non-WebRTC-named header guard, which could conflict with other similarly named/intended headers. BUG=None NO_DEPENDENCY_CHECKS=true ==========
lgtm, though you already had that from tommi
The CQ bit was checked by noahric@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481576960102370, "parent_rev": "2b764e0e75431861de7ec7cd01f1c1765663559b", "commit_rev": "880aefa7b073161382f67b3b1f7571fa07bc26c6"}
Message was sent while issue was closed.
Description was changed from ========== Fix header guard in thread_annotations.h. It was using a non-WebRTC-named header guard, which could conflict with other similarly named/intended headers. BUG=None NO_DEPENDENCY_CHECKS=true ========== to ========== Fix header guard in thread_annotations.h. It was using a non-WebRTC-named header guard, which could conflict with other similarly named/intended headers. BUG=None NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.webrtc.org/2548113002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix header guard in thread_annotations.h. It was using a non-WebRTC-named header guard, which could conflict with other similarly named/intended headers. BUG=None NO_DEPENDENCY_CHECKS=true Review-Url: https://codereview.webrtc.org/2548113002 ========== to ========== Fix header guard in thread_annotations.h. It was using a non-WebRTC-named header guard, which could conflict with other similarly named/intended headers. BUG=None NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/580df537ce829818448f0563c8aded6fc63b886b Cr-Commit-Position: refs/heads/master@{#15554} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/580df537ce829818448f0563c8aded6fc63b886b Cr-Commit-Position: refs/heads/master@{#15554} |