Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2548113002: Fix header guard in thread_annotations.h. (Closed)

Created:
4 years ago by noahric
Modified:
4 years ago
Reviewers:
tommi, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix header guard in thread_annotations.h. It was using a non-WebRTC-named header guard, which could conflict with other similarly named/intended headers. BUG=None NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/580df537ce829818448f0563c8aded6fc63b886b Cr-Commit-Position: refs/heads/master@{#15554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/base/thread_annotations.h View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (12 generated)
noahric
4 years ago (2016-12-03 01:58:29 UTC) #4
noahric
I'm not sure if this is enough; it may also be a good idea to ...
4 years ago (2016-12-03 02:26:13 UTC) #7
tommi
lgtm
4 years ago (2016-12-03 16:00:57 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2544003005 Patch 20001). Please resolve the dependency and ...
4 years ago (2016-12-03 16:01:06 UTC) #11
mflodman
lgtm, though you already had that from tommi
4 years ago (2016-12-07 15:29:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2548113002/1
4 years ago (2016-12-12 21:09:22 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 21:36:50 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 21:36:59 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/580df537ce829818448f0563c8aded6fc63b886b
Cr-Commit-Position: refs/heads/master@{#15554}

Powered by Google App Engine
This is Rietveld 408576698