Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2544003005: Destroy encoders that fail to InitEncode. (Closed)

Created:
4 years ago by noahric
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Destroy encoders that fail to InitEncode. SimulcastEncoderAdapter calls Release() on a failed sub-encoder init, but Release only knows how to clean up encoders that have registered stream info. Since failed ones don't register, they aren't currently cleaned up. BUG=None Committed: https://crrev.com/e5ba75a658b697d1a8fd1944edf865a6e4d400f1 Cr-Commit-Position: refs/heads/master@{#15553}

Patch Set 1 #

Patch Set 2 : Remove extra blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 5 chunks +24 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
noahric
4 years ago (2016-12-02 21:40:32 UTC) #4
sophiechang-webrtc
lgtm
4 years ago (2016-12-07 01:18:01 UTC) #12
stefan-webrtc
lgtm
4 years ago (2016-12-07 08:05:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2544003005/20001
4 years ago (2016-12-12 20:52:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 21:08:31 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 21:08:42 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5ba75a658b697d1a8fd1944edf865a6e4d400f1
Cr-Commit-Position: refs/heads/master@{#15553}

Powered by Google App Engine
This is Rietveld 408576698