Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2541453002: Delete unused classes AutoDetectProxy and SslSocketFactory. (Closed)

Created:
4 years ago by nisse-webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused classes AutoDetectProxy and SslSocketFactory. SslSocketFactory is unused since https://codereview.webrtc.org/2506983002, and it's the last user of AutoDetectProxy. Also move HttpListenServer and SocksProxyServer to the rtc_base_tests_utils gn target, since they're used by tests only. BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2541453002 Cr-Commit-Position: refs/heads/master@{#16576} Committed: https://chromium.googlesource.com/external/webrtc/+/14584623035b29ce2a7830ea38956a10c584248d

Patch Set 1 #

Patch Set 2 : Delete unused proxy detection code. Move proxyserver and httpserver to a test target. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2351 lines) Patch
M webrtc/base/BUILD.gn View 1 2 8 chunks +4 lines, -12 lines 0 comments Download
D webrtc/base/autodetectproxy.h View 1 1 chunk +0 lines, -90 lines 0 comments Download
D webrtc/base/autodetectproxy.cc View 1 2 1 chunk +0 lines, -302 lines 0 comments Download
D webrtc/base/autodetectproxy_unittest.cc View 1 1 chunk +0 lines, -131 lines 0 comments Download
M webrtc/base/proxy_unittest.cc View 1 4 chunks +0 lines, -58 lines 0 comments Download
D webrtc/base/proxydetect.h View 1 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/base/proxydetect.cc View 1 2 1 chunk +0 lines, -1292 lines 0 comments Download
D webrtc/base/proxydetect_unittest.cc View 1 1 chunk +0 lines, -164 lines 0 comments Download
D webrtc/base/sslsocketfactory.h View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/base/sslsocketfactory.cc View 1 2 1 chunk +0 lines, -197 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
nisse-webrtc
4 years ago (2016-11-29 12:06:18 UTC) #3
pthatcher1
lgtm
4 years ago (2016-11-30 00:38:46 UTC) #6
kjellander_webrtc
let's run the chromium trybots and the internal one as well. lgtm
4 years ago (2016-11-30 08:08:40 UTC) #7
nisse-webrtc
On 2016/11/30 08:08:40, kjellander_webrtc wrote: > let's run the chromium trybots and the internal one ...
4 years ago (2016-11-30 08:18:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2541453002/40001
3 years, 10 months ago (2017-02-13 10:50:34 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 12:33:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/14584623035b29ce2a7830ea3...

Powered by Google App Engine
This is Rietveld 408576698