Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2506983002: Delete unused files httprequest.h and httprequest.cc. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc
Modified:
4 years, 1 month ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused files httprequest.h and httprequest.cc. This is a partial reland of cl https://codereview.webrtc.org/2366333002, without deleting httpclient.h. BUG=webrtc:6424 Committed: https://crrev.com/d51c4dccd726a2db7497e378e1c17815b7c4a340 Cr-Commit-Position: refs/heads/master@{#15130}

Patch Set 1 #

Patch Set 2 : Rebase (base.gyp gone) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -232 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/base/httprequest.h View 1 chunk +0 lines, -116 lines 0 comments Download
D webrtc/base/httprequest.cc View 1 chunk +0 lines, -114 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
nisse-webrtc
4 years, 1 month ago (2016-11-16 08:21:33 UTC) #2
nisse-webrtc
Tommi, can you have a look? Peter is OOO for a week (busy with IETF, ...
4 years, 1 month ago (2016-11-17 10:21:12 UTC) #4
tommi
lgtm
4 years, 1 month ago (2016-11-17 11:26:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2506983002/1
4 years, 1 month ago (2016-11-17 12:38:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/12963) android_more_configs on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-11-17 12:39:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2506983002/20001
4 years, 1 month ago (2016-11-17 12:42:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 13:54:39 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 13:54:51 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d51c4dccd726a2db7497e378e1c17815b7c4a340
Cr-Commit-Position: refs/heads/master@{#15130}

Powered by Google App Engine
This is Rietveld 408576698