Delete unused code httprequest, httpclient, and socketpool.

Delete unused code httprequest, httpclient, and socketpool.

BUG=webrtc:6424
Committed: https://crrev.com/4a255be3790a040cae2f6182ed70b7dd38c6839e
Cr-Commit-Position: refs/heads/master@{#14514}

[nisse-webrtc, 2016-09-26 11:52:45]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org

[nisse-webrtc, 2016-09-26 11:52:46]

I'm having some difficulty digging up when and where this was ever used.

[nisse-webrtc, 2016-09-26 12:20:43]

On 2016/09/26 11:52:46, nisse-webrtc wrote:
> I'm having some difficulty digging up when and where this was ever used.

At a second look, it seems base/httpclient.* is unused too. I'll update cl to
delete those.

base/httpserver.*, on the other hand, is used by some unit tests.

[nisse-webrtc, 2016-09-26 13:33:41]

Description was changed from

==========
Delete unused code base/httprequest.{cc,h}.

BUG=None.
==========

to

==========
Delete unused code base/httprequest.{cc,h}.

BUG=webrtc:6424
==========

[nisse-webrtc, 2016-09-28 12:59:15]

Description was changed from

==========
Delete unused code base/httprequest.{cc,h}.

BUG=webrtc:6424
==========

to

==========
Delete unused code httprequest, httpclient, and socketpool.

BUG=webrtc:6424
==========

[pthatcher1, 2016-10-03 22:38:06]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-10-03 22:38:07]

lgtm

It was used in the HttpPortAllocatorBase, which is no longer used. While you're
deleting things, can you delete it as well?

[nisse-webrtc, 2016-10-04 08:02:59]

On 2016/10/03 22:38:07, pthatcher1 wrote:
> lgtm
> 
> It was used in the HttpPortAllocatorBase, which is no longer used. While
you're
> deleting things, can you delete it as well?

httpportallocator.h is included in chrome's
remoting/protocol/ice_transport_channel.cc, 
and I'm afraid there are a couple of other places in downstream projects. So I
think that's
for a separate cl.

[nisse-webrtc, 2016-10-04 08:03:08]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-10-04 08:03:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-04 10:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 10:03:41]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[nisse-webrtc, 2016-10-05 06:17:49]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-10-05 06:17:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-05 06:29:52]

Description was changed from

==========
Delete unused code httprequest, httpclient, and socketpool.

BUG=webrtc:6424
==========

to

==========
Delete unused code httprequest, httpclient, and socketpool.

BUG=webrtc:6424
==========

[commit-bot: I haz the power, 2016-10-05 06:29:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 06:29:58]

Description was changed from

==========
Delete unused code httprequest, httpclient, and socketpool.

BUG=webrtc:6424
==========

to

==========
Delete unused code httprequest, httpclient, and socketpool.

BUG=webrtc:6424

Committed: https://crrev.com/4a255be3790a040cae2f6182ed70b7dd38c6839e
Cr-Commit-Position: refs/heads/master@{#14514}
==========

[commit-bot: I haz the power, 2016-10-05 06:29:59]

Patchset 3 (id:??) landed as
https://crrev.com/4a255be3790a040cae2f6182ed70b7dd38c6839e
Cr-Commit-Position: refs/heads/master@{#14514}

[ivoc, 2016-10-05 08:23:02]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2397673002/ by ivoc@webrtc.org.

The reason for reverting is: This CL breaks some downstream dependencies
(contact me for more info)..