Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2536553003: Update the alpha value in the echo detector. (Closed)

Created:
4 years ago by ivoc
Modified:
4 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/pending/branch-heads/56
Project:
webrtc
Visibility:
Public.

Description

Update the alpha value in the echo detector. BUG=webrtc:6525, chromium:668704 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2506643002 Cr-Commit-Position: refs/heads/master@{#15136} (cherry picked from commit 765edc34257a439bb3d9acc7d4c6aaf205b4e11f)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M webrtc/modules/audio_processing/echo_detector/mean_variance_estimator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_detector/mean_variance_estimator_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/echo_detector/normalized_covariance_estimator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/residual_echo_detector_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536553003/1
4 years ago (2016-11-28 13:29:54 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-11-28 13:29:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536553003/1
4 years ago (2016-11-28 13:31:34 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years ago (2016-11-28 13:31:35 UTC) #10
hlundin-webrtc
lgtm
4 years ago (2016-11-28 13:40:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2536553003/1
4 years ago (2016-11-28 14:23:56 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-28 15:01:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698