Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2506643002: Update the alpha value in the echo detector. (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update the alpha value in the echo detector. BUG=webrtc:6525 Committed: https://crrev.com/765edc34257a439bb3d9acc7d4c6aaf205b4e11f Cr-Commit-Position: refs/heads/master@{#15136}

Patch Set 1 #

Patch Set 2 : Relaxed some of the unittests due to the slower adaption caused by the lower alpha values. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M webrtc/modules/audio_processing/echo_detector/mean_variance_estimator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_detector/mean_variance_estimator_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/echo_detector/normalized_covariance_estimator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/residual_echo_detector_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
ivoc
Hi Per, I just noticed that I made a mistake in setting the original alpha ...
4 years, 1 month ago (2016-11-15 14:59:02 UTC) #3
ivoc
Adding Henrik as reviewer since Per is busy travelling. Henrik: PTAL.
4 years, 1 month ago (2016-11-16 09:27:58 UTC) #5
hlundin-webrtc
lgtm
4 years, 1 month ago (2016-11-16 09:42:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2506643002/1
4 years, 1 month ago (2016-11-16 11:56:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16260)
4 years, 1 month ago (2016-11-16 12:01:30 UTC) #10
ivoc
Since the lower alpha values cause slower adaptation, I had to relax some of the ...
4 years, 1 month ago (2016-11-17 13:50:00 UTC) #11
hlundin-webrtc
Still lgtm.
4 years, 1 month ago (2016-11-17 13:56:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2506643002/20001
4 years, 1 month ago (2016-11-17 13:57:33 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 15:10:19 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 15:10:32 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/765edc34257a439bb3d9acc7d4c6aaf205b4e11f
Cr-Commit-Position: refs/heads/master@{#15136}

Powered by Google App Engine
This is Rietveld 408576698