Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2509703002: Remove all references to GYP (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhuangzesen_agora.io, tlegrand-webrtc, qiang.lu, peah-webrtc, bjornv1, video-team_agora.io, tterriberry_mozilla.com, fengyue_agora.io, sdk-team_agora.io, minyue-webrtc, mflodman, Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, kwiberg-webrtc, danilchap, henrika_webrtc, audio-team_agora.io, hlundin-webrtc, niklas.enbom, the sun, perkj_webrtc, aluebs-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove all references to GYP Remove all .gyp and .gypi files. Remove entries from OWNERS files for *.isolate, *.gyp, *.gypi Remove unused scripts in webrtc/build. BUG=webrtc:6323 R=henrika@webrtc.org, phoglund@webrtc.org Committed: https://crrev.com/b4af3d673af46e1d2e858a9d471782db4ae2b503 Cr-Commit-Position: refs/heads/master@{#15107}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Restored tools/gyp #

Total comments: 2

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15984 lines) Patch
M .gitignore View 1 1 chunk +0 lines, -1 line 0 comments Download
M PRESUBMIT.py View 7 chunks +8 lines, -91 lines 0 comments Download
D all.gyp View 1 chunk +0 lines, -67 lines 0 comments Download
M sync_chromium.py View 1 3 chunks +1 line, -6 lines 0 comments Download
M third_party/gflags/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download
D third_party/gflags/gflags.gyp View 1 chunk +0 lines, -95 lines 0 comments Download
M third_party/winsdk_samples/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download
D third_party/winsdk_samples/winsdk_samples.gyp View 1 chunk +0 lines, -127 lines 0 comments Download
M webrtc/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/api/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/api/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/android/README View 1 chunk +2 lines, -1 line 0 comments Download
D webrtc/api/api.gyp View 1 chunk +0 lines, -249 lines 0 comments Download
D webrtc/api/api_java.gyp View 1 chunk +0 lines, -50 lines 0 comments Download
M webrtc/api/stats/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/audio/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/audio/webrtc_audio.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
M webrtc/base/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/base/base.gyp View 1 chunk +0 lines, -655 lines 0 comments Download
D webrtc/base/base_tests.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
M webrtc/build/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/build/arm_neon.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/build/chromium_common.gypi View 1 chunk +0 lines, -5973 lines 0 comments Download
D webrtc/build/common.gypi View 1 chunk +0 lines, -594 lines 0 comments Download
D webrtc/build/download_vs_toolchain.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/build/filename_rules.gypi View 1 chunk +0 lines, -105 lines 0 comments Download
D webrtc/build/find_directx_sdk.py View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/build/gyp_webrtc View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/build/gyp_webrtc.py View 1 chunk +0 lines, -181 lines 0 comments Download
D webrtc/build/ios/merge_ios_libs.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/build/ios/objc_app.gypi View 1 chunk +0 lines, -33 lines 0 comments Download
D webrtc/build/isolate.gypi View 1 chunk +0 lines, -142 lines 0 comments Download
M webrtc/build/mb_config.pyl View 17 chunks +7 lines, -101 lines 0 comments Download
D webrtc/build/merge_libs.gyp View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/build/merge_libs_voice.gyp View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/build/merge_voice_libs.gyp View 1 chunk +0 lines, -43 lines 0 comments Download
D webrtc/build/objc_common.gypi View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/build/protoc.gypi View 1 chunk +0 lines, -136 lines 0 comments Download
M webrtc/call/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/call/webrtc_call.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/common.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/common_audio/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/common_audio/common_audio.gyp View 1 chunk +0 lines, -232 lines 0 comments Download
M webrtc/common_video/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/common_video/common_video.gyp View 1 2 1 chunk +0 lines, -86 lines 0 comments Download
M webrtc/examples/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/libjingle/xmllite/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/libjingle/xmllite/xmllite.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
M webrtc/libjingle/xmpp/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpp.gyp View 1 chunk +0 lines, -142 lines 0 comments Download
M webrtc/media/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/media/media.gyp View 1 chunk +0 lines, -152 lines 0 comments Download
M webrtc/modules/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_coding/audio_coding.gypi View 1 chunk +0 lines, -195 lines 0 comments Download
D webrtc/modules/audio_coding/audio_coding_tests.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor.gypi View 1 chunk +0 lines, -83 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/cng/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/cng/cng.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g711/g711.gypi View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g722/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/g722/g722.gypi View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/ilbc/ilbc.gypi View 1 chunk +0 lines, -166 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/interfaces.gypi View 1 chunk +0 lines, -39 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/fix/source/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/isac.gypi View 1 chunk +0 lines, -95 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/isac_common.gypi View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/isac_test.gypi View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/isacfix.gypi View 1 chunk +0 lines, -146 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/isacfix_test.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/isac/main/source/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/opus/opus.gypi View 1 chunk +0 lines, -54 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/pcm16b/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/red/red.gypi View 1 chunk +0 lines, -33 lines 0 comments Download
D webrtc/modules/audio_coding/codecs/tools/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +0 lines, -137 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 chunk +0 lines, -312 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_conference_mixer/audio_conference_mixer.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/modules/audio_conference_mixer/source/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_device/audio_device.gypi View 1 chunk +0 lines, -262 lines 0 comments Download
M webrtc/modules/audio_mixer/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_mixer/audio_mixer.gypi View 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/modules/audio_processing/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +0 lines, -332 lines 0 comments Download
D webrtc/modules/audio_processing/audio_processing_tests.gypi View 1 chunk +0 lines, -151 lines 0 comments Download
M webrtc/modules/bitrate_controller/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/bitrate_controller/bitrate_controller.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
M webrtc/modules/congestion_controller/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/congestion_controller/congestion_controller.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
M webrtc/modules/desktop_capture/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/desktop_capture/desktop_capture.gypi View 1 chunk +0 lines, -198 lines 0 comments Download
M webrtc/modules/media_file/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/media_file/media_file.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/modules/modules.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
M webrtc/modules/pacing/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/pacing/pacing.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 chunk +0 lines, -118 lines 0 comments Download
M webrtc/modules/rtp_rtcp/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +0 lines, -187 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/rtp_rtcp/test/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/rtp_rtcp/test/testFec/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/rtp_rtcp/test/testFec/test_fec.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/modules/utility/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/utility/source/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/utility/utility.gypi View 1 chunk +0 lines, -42 lines 0 comments Download
M webrtc/modules/video_capture/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/modules/video_capture/video_capture.gypi View 1 chunk +0 lines, -152 lines 0 comments Download
M webrtc/modules/video_coding/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264.gypi View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/codecs/i420/i420.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D webrtc/modules/video_coding/codecs/test/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/codecs/test/video_codecs_test_framework.gypi View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/modules/video_coding/codecs/tools/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/codecs/tools/video_codecs_tools.gypi View 1 chunk +0 lines, -36 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp8/vp8.gyp View 1 chunk +0 lines, -73 lines 0 comments Download
D webrtc/modules/video_coding/codecs/vp9/vp9.gyp View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/modules/video_coding/utility/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/modules/video_coding/video_coding.gypi View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
D webrtc/modules/video_coding/video_coding_test.gypi View 1 chunk +0 lines, -35 lines 0 comments Download
M webrtc/modules/video_processing/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/video_processing/video_processing.gypi View 1 chunk +0 lines, -90 lines 0 comments Download
M webrtc/p2p/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -135 lines 0 comments Download
M webrtc/pc/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/pc/pc.gyp View 1 chunk +0 lines, -75 lines 0 comments Download
M webrtc/sdk/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/sdk/sdk.gyp View 1 chunk +0 lines, -379 lines 0 comments Download
D webrtc/sdk/sdk.gypi View 1 chunk +0 lines, -26 lines 0 comments Download
M webrtc/stats/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/stats/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/stats/stats.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/supplement.gypi View 1 chunk +0 lines, -60 lines 0 comments Download
M webrtc/system_wrappers/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/system_wrappers/cpu_features_chromium.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/system_wrappers/cpu_features_webrtc.gyp View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/system_wrappers/source/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/system_wrappers/system_wrappers.gyp View 1 chunk +0 lines, -171 lines 0 comments Download
M webrtc/test/OWNERS View 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/test/test.gyp View 1 chunk +0 lines, -296 lines 0 comments Download
M webrtc/tools/OWNERS View 1 chunk +0 lines, -7 lines 0 comments Download
D webrtc/tools/internal_tools.gyp View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/tools/tools.gyp View 1 chunk +0 lines, -146 lines 0 comments Download
M webrtc/video/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/video/webrtc_video.gypi View 1 chunk +0 lines, -64 lines 0 comments Download
M webrtc/voice_engine/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/voice_engine/voice_engine.gyp View 1 chunk +0 lines, -114 lines 0 comments Download
D webrtc/webrtc.gyp View 1 chunk +0 lines, -130 lines 0 comments Download
D webrtc/webrtc_examples.gyp View 1 chunk +0 lines, -482 lines 0 comments Download
D webrtc/webrtc_tests.gypi View 1 chunk +0 lines, -84 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
kjellander_webrtc
phoglund: main reviewer, but I think you only need to look at .gitignore PRESUBMIT.py setup_links.py ...
4 years, 1 month ago (2016-11-16 15:18:56 UTC) #2
henrika_webrtc
LGTM
4 years, 1 month ago (2016-11-16 15:20:35 UTC) #3
henrika_webrtc
LGTM
4 years, 1 month ago (2016-11-16 15:20:36 UTC) #4
phoglund
On 2016/11/16 15:20:36, henrika_webrtc wrote: > LGTM lgtm. Skiten måste bort! Looks like the landmines ...
4 years, 1 month ago (2016-11-16 15:35:52 UTC) #5
ehmaldonado_webrtc
https://codereview.webrtc.org/2509703002/diff/1/sync_chromium.py File sync_chromium.py (right): https://codereview.webrtc.org/2509703002/diff/1/sync_chromium.py#newcode118 sync_chromium.py:118: env.setdefault('GYP_DEFINES', '') What about this?
4 years, 1 month ago (2016-11-16 16:07:41 UTC) #6
kjellander_webrtc
https://codereview.webrtc.org/2509703002/diff/1/sync_chromium.py File sync_chromium.py (right): https://codereview.webrtc.org/2509703002/diff/1/sync_chromium.py#newcode118 sync_chromium.py:118: env.setdefault('GYP_DEFINES', '') On 2016/11/16 16:07:41, ehmaldonado_webrtc wrote: > What ...
4 years, 1 month ago (2016-11-16 16:39:27 UTC) #7
the sun
https://codereview.webrtc.org/2509703002/diff/40001/.gitignore File .gitignore (right): https://codereview.webrtc.org/2509703002/diff/40001/.gitignore#newcode155 .gitignore:155: /tools/gyp Goes later?
4 years, 1 month ago (2016-11-16 18:28:18 UTC) #10
kjellander_webrtc
https://codereview.webrtc.org/2509703002/diff/40001/.gitignore File .gitignore (right): https://codereview.webrtc.org/2509703002/diff/40001/.gitignore#newcode155 .gitignore:155: /tools/gyp On 2016/11/16 18:28:18, the sun wrote: > Goes ...
4 years, 1 month ago (2016-11-16 18:33:47 UTC) #13
kjellander_webrtc
4 years, 1 month ago (2016-11-16 19:11:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
b4af3d673af46e1d2e858a9d471782db4ae2b503 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698