Remove all references to GYP

PRESUBMIT.py

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import os
 import re
@@ skipping 209 matching lines @@
     if input_api.is_committing:
       # TODO(kjellander): Change back to PresubmitError below when we're
       # confident with the lint settings.
       res_type = output_api.PresubmitPromptWarning
     else:
       res_type = output_api.PresubmitPromptWarning
     result = [res_type('Changelist failed cpplint.py check.')]
 
   return result
 
-def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api):
-  pattern = input_api.re.compile(r"base.gyp:rtc_base\s*'")
-  violating_files = []
-  for f in gyp_files:
-    gyp_exceptions = (
-        'audio_device.gypi',
-        'base_tests.gyp',
-        'desktop_capture.gypi',
-        'p2p.gyp',
-        'sdk.gyp',
-        'webrtc_test_common.gyp',
-        'webrtc_tests.gypi',
-    )
-    if f.LocalPath().endswith(gyp_exceptions):
-      continue
-    contents = input_api.ReadFile(f)
-    if pattern.search(contents):
-      violating_files.append(f)
-  if violating_files:
-    return [output_api.PresubmitError(
-        'Depending on rtc_base is not allowed. Change your dependency to '
-        'rtc_base_approved and possibly sanitize and move the desired source '
-        'file(s) to rtc_base_approved.\nChanged GYP files:',
-        items=violating_files)]
-  return []
-
-def _CheckNoRtcBaseDepsGn(input_api, gn_files, output_api):
+def _CheckNoRtcBaseDeps(input_api, gn_files, output_api):
   pattern = input_api.re.compile(r'base:rtc_base\s*"')
   violating_files = []
   for f in gn_files:
     gn_exceptions = (
         os.path.join('audio_device', 'BUILD.gn'),
         os.path.join('base_tests', 'BUILD.gn'),
         os.path.join('desktop_capture', 'BUILD.gn'),
         os.path.join('p2p', 'BUILD.gn'),
         os.path.join('sdk', 'BUILD.gn'),
         os.path.join('webrtc_test_common', 'BUILD.gn'),
@@ skipping 14 matching lines @@
     if pattern.search(contents):
       violating_files.append(f)
   if violating_files:
     return [output_api.PresubmitError(
         'Depending on rtc_base is not allowed. Change your dependency to '
         'rtc_base_approved and possibly sanitize and move the desired source '
         'file(s) to rtc_base_approved.\nChanged GN files:',
         items=violating_files)]
   return []
 
-def _CheckNoSourcesAboveGyp(input_api, gyp_files, output_api):
-  # Disallow referencing source files with paths above the GYP file location.
-  source_pattern = input_api.re.compile(r'\'sources\'.*?\[(.*?)\]',
-                                        re.MULTILINE | re.DOTALL)
-  file_pattern = input_api.re.compile(r"'((\.\./.*?)|(<\(webrtc_root\).*?))'")
-  violating_gyp_files = set()
-  violating_source_entries = []
-  for gyp_file in gyp_files:
-    if 'supplement.gypi' in gyp_file.LocalPath():
-      # Exclude supplement.gypi from this check, as the LSan and TSan
-      # suppression files are located in a different location.
-      continue
-    contents = input_api.ReadFile(gyp_file)
-    for source_block_match in source_pattern.finditer(contents):
-      # Find all source list entries starting with ../ in the source block
-      # (exclude overrides entries).
-      for file_list_match in file_pattern.finditer(source_block_match.group(1)):
-        source_file = file_list_match.group(1)
-        if 'overrides/' not in source_file:
-          violating_source_entries.append(source_file)
-          violating_gyp_files.add(gyp_file)
-  if violating_gyp_files:
-    return [output_api.PresubmitError(
-        'Referencing source files above the directory of the GYP file is not '
-        'allowed. Please introduce new GYP targets and/or GYP files in the '
-        'proper location instead.\n'
-        'Invalid source entries:\n'
-        '%s\n'
-        'Violating GYP files:' % '\n'.join(violating_source_entries),
-        items=violating_gyp_files)]
-  return []
 
-def _CheckNoSourcesAboveGn(input_api, gn_files, output_api):
+def _CheckNoSourcesAbove(input_api, gn_files, output_api):
   # Disallow referencing source files with paths above the GN file location.
   source_pattern = input_api.re.compile(r' +sources \+?= \[(.*?)\]',
                                         re.MULTILINE | re.DOTALL)
   file_pattern = input_api.re.compile(r'"((\.\./.*?)|(//.*?))"')
   violating_gn_files = set()
   violating_source_entries = []
   for gn_file in gn_files:
     contents = input_api.ReadFile(gn_file)
     for source_block_match in source_pattern.finditer(contents):
       # Find all source list entries starting with ../ in the source block
       # (exclude overrides entries).
       for file_list_match in file_pattern.finditer(source_block_match.group(1)):
         source_file = file_list_match.group(1)
         if 'overrides/' not in source_file:
           violating_source_entries.append(source_file)
           violating_gn_files.add(gn_file)
   if violating_gn_files:
     return [output_api.PresubmitError(
         'Referencing source files above the directory of the GN file is not '
-        'allowed. Please introduce new GYP targets and/or GN files in the '
-        'proper location instead.\n'
+        'allowed. Please introduce new GN targets in the proper location '
+        'instead.\n'
         'Invalid source entries:\n'
         '%s\n'
         'Violating GN files:' % '\n'.join(violating_source_entries),
         items=violating_gn_files)]
   return []
 
-def _CheckGypChanges(input_api, output_api):
-  source_file_filter = lambda x: input_api.FilterSourceFile(
-      x, white_list=(r'.+\.(gyp|gypi)$',))
-
-  gyp_files = []
-  for f in input_api.AffectedSourceFiles(source_file_filter):
-    if f.LocalPath().startswith('webrtc'):
-      gyp_files.append(f)
-
-  result = []
-  if gyp_files:
-    result.append(output_api.PresubmitNotifyResult(
-        'As you\'re changing GYP files: please make sure corresponding '
-        'BUILD.gn files are also updated.\nChanged GYP files:',
-        items=gyp_files))
-    result.extend(_CheckNoRtcBaseDeps(input_api, gyp_files, output_api))
-    result.extend(_CheckNoSourcesAboveGyp(input_api, gyp_files, output_api))
-  return result
-
 def _CheckGnChanges(input_api, output_api):
   source_file_filter = lambda x: input_api.FilterSourceFile(
       x, white_list=(r'.+\.(gn|gni)$',))
 
   gn_files = []
   for f in input_api.AffectedSourceFiles(source_file_filter):
     if f.LocalPath().startswith('webrtc'):
       gn_files.append(f)
 
   result = []
   if gn_files:
-    result.append(output_api.PresubmitNotifyResult(
-        'As you\'re changing GN files: please make sure corresponding GYP'
-        'files are also updated.\nChanged GN files:',
-        items=gn_files))
-    result.extend(_CheckNoRtcBaseDepsGn(input_api, gn_files, output_api))
-    result.extend(_CheckNoSourcesAboveGn(input_api, gn_files, output_api))
+    result.extend(_CheckNoRtcBaseDeps(input_api, gn_files, output_api))
+    result.extend(_CheckNoSourcesAbove(input_api, gn_files, output_api))
   return result
 
 def _CheckUnwantedDependencies(input_api, output_api):
   """Runs checkdeps on #include statements added in this
   change. Breaking - rules is an error, breaking ! rules is a
   warning.
   """
   # Copied from Chromium's src/PRESUBMIT.py.
 
   # We need to wait until we have an input_api object and use this
@@ skipping 130 matching lines @@
                   r'^buildtools[\\\/].*\.py$',
                   r'^chromium[\\\/].*\.py$',
                   r'^mojo.*[\\\/].*\.py$',
                   r'^out.*[\\\/].*\.py$',
                   r'^testing[\\\/].*\.py$',
                   r'^third_party[\\\/].*\.py$',
                   r'^tools[\\\/]clang[\\\/].*\.py$',
                   r'^tools[\\\/]generate_library_loader[\\\/].*\.py$',
                   r'^tools[\\\/]generate_stubs[\\\/].*\.py$',
                   r'^tools[\\\/]gn[\\\/].*\.py$',
-                  r'^tools[\\\/]gyp[\\\/].*\.py$',
                   r'^tools[\\\/]isolate_driver.py$',
                   r'^tools[\\\/]mb[\\\/].*\.py$',
                   r'^tools[\\\/]protoc_wrapper[\\\/].*\.py$',
                   r'^tools[\\\/]python[\\\/].*\.py$',
                   r'^tools[\\\/]python_charts[\\\/]data[\\\/].*\.py$',
                   r'^tools[\\\/]refactoring[\\\/].*\.py$',
                   r'^tools[\\\/]swarming_client[\\\/].*\.py$',
                   r'^tools[\\\/]vim[\\\/].*\.py$',
                   # TODO(phoglund): should arguably be checked.
                   r'^tools[\\\/]valgrind-webrtc[\\\/].*\.py$',
                   r'^tools[\\\/]valgrind[\\\/].*\.py$',
                   r'^tools[\\\/]win[\\\/].*\.py$',
                   r'^xcodebuild.*[\\\/].*\.py$',),
       disabled_warnings=['F0401',  # Failed to import x
                          'E0611',  # No package y in x
                          'W0232',  # Class has no __init__ method
                         ],
       pylintrc='pylintrc'))
 
   # TODO(nisse): talk/ is no more, so make below checks simpler?
   # WebRTC can't use the presubmit_canned_checks.PanProjectChecks function since
   # we need to have different license checks in talk/ and webrtc/ directories.
   # Instead, hand-picked checks are included below.
 
   # .m and .mm files are ObjC files. For simplicity we will consider .h files in
   # ObjC subdirectories ObjC headers.
   objc_filter_list = (r'.+\.m$', r'.+\.mm$', r'.+objc\/.+\.h$')
-  # Skip long-lines check for DEPS, GN and GYP files.
-  build_file_filter_list = (r'.+\.gyp$', r'.+\.gypi$', r'.+\.gn$', r'.+\.gni$',
-      'DEPS')
+  # Skip long-lines check for DEPS and GN files.
+  build_file_filter_list = (r'.+\.gn$', r'.+\.gni$', 'DEPS')
   eighty_char_sources = lambda x: input_api.FilterSourceFile(x,
       black_list=build_file_filter_list + objc_filter_list)
   hundred_char_sources = lambda x: input_api.FilterSourceFile(x,
       white_list=objc_filter_list)
   results.extend(input_api.canned_checks.CheckLongLines(
       input_api, output_api, maxlen=80, source_file_filter=eighty_char_sources))
   results.extend(input_api.canned_checks.CheckLongLines(
       input_api, output_api, maxlen=100,
       source_file_filter=hundred_char_sources))
 
   results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeTodoHasOwner(
       input_api, output_api))
   results.extend(_CheckNativeApiHeaderChanges(input_api, output_api))
   results.extend(_CheckNoIOStreamInHeaders(input_api, output_api))
   results.extend(_CheckNoFRIEND_TEST(input_api, output_api))
-  results.extend(_CheckGypChanges(input_api, output_api))
   results.extend(_CheckGnChanges(input_api, output_api))
   results.extend(_CheckUnwantedDependencies(input_api, output_api))
   results.extend(_CheckJSONParseErrors(input_api, output_api))
   results.extend(_RunPythonTests(input_api, output_api))
   return results
 
 
 def CheckChangeOnUpload(input_api, output_api):
   results = []
   results.extend(_CommonChecks(input_api, output_api))
@@ skipping 11 matching lines @@
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasDescription(
       input_api, output_api))
   results.extend(_CheckChangeHasBugField(input_api, output_api))
   results.extend(input_api.canned_checks.CheckChangeHasTestField(
       input_api, output_api))
   results.extend(input_api.canned_checks.CheckTreeIsOpen(
       input_api, output_api,
       json_url='http://webrtc-status.appspot.com/current?format=json'))
   return results