Chromium Code Reviews Chromium Code Reviews
Issue 2509703002:
Remove all references to GYP (Closed)
| OLD | NEW |
|---|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. | 2 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. |
| 3 # | 3 # |
| 4 # Use of this source code is governed by a BSD-style license | 4 # Use of this source code is governed by a BSD-style license |
| 5 # that can be found in the LICENSE file in the root of the source | 5 # that can be found in the LICENSE file in the root of the source |
| 6 # tree. An additional intellectual property rights grant can be found | 6 # tree. An additional intellectual property rights grant can be found |
| 7 # in the file PATENTS. All contributing project authors may | 7 # in the file PATENTS. All contributing project authors may |
| 8 # be found in the AUTHORS file in the root of the source tree. | 8 # be found in the AUTHORS file in the root of the source tree. |
| 9 | 9 |
| 10 """Script to download a Chromium checkout into the workspace. | 10 """Script to download a Chromium checkout into the workspace. |
| (...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 108 | 108 |
| 109 # Workaround to avoid sync failure due move in | 109 # Workaround to avoid sync failure due move in |
| 110 # https://codereview.chromium.org/1155743013 | 110 # https://codereview.chromium.org/1155743013 |
| 111 # TODO(kjellander): Remove this after the summer of 2015. | 111 # TODO(kjellander): Remove this after the summer of 2015. |
| 112 freetype_src = os.path.join(CR_DIR, 'src', 'third_party', 'freetype-android', | 112 freetype_src = os.path.join(CR_DIR, 'src', 'third_party', 'freetype-android', |
| 113 'src') | 113 'src') |
| 114 if os.path.isdir(freetype_src): | 114 if os.path.isdir(freetype_src): |
| 115 shutil.rmtree(freetype_src) | 115 shutil.rmtree(freetype_src) |
| 116 | 116 |
| 117 # Avoid downloading NaCl toolchain as part of the Chromium hooks. | 117 # Avoid downloading NaCl toolchain as part of the Chromium hooks. |
| 118 env.setdefault('GYP_DEFINES', '') | 118 env.setdefault('GYP_DEFINES', '') |
|
ehmaldonado_webrtc
2016/11/16 16:07:41
What about this?
kjellander_webrtc
2016/11/16 16:39:27
Yeah let's remove it.
| |
| 119 env['GYP_DEFINES'] += ' disable_nacl=1' | |
| 120 env['GYP_CHROMIUM_NO_ACTION'] = '1' | |
| 121 gclient_cmd = 'gclient.bat' if sys.platform.startswith('win') else 'gclient' | 119 gclient_cmd = 'gclient.bat' if sys.platform.startswith('win') else 'gclient' |
| 122 args = [ | 120 args = [ |
| 123 gclient_cmd, 'sync', '--force', '--revision', 'src@'+opts.target_revision | 121 gclient_cmd, 'sync', '--force', '--revision', 'src@'+opts.target_revision |
| 124 ] | 122 ] |
| 125 | 123 |
| 126 if os.environ.get('CHROME_HEADLESS') == '1': | 124 if os.environ.get('CHROME_HEADLESS') == '1': |
| 127 # Running on a buildbot. | 125 # Running on a buildbot. |
| 128 args.append('-vvv') | 126 args.append('-vvv') |
| 129 | 127 |
| 130 if sys.platform.startswith('win'): | 128 if sys.platform.startswith('win'): |
| (...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 186 ret = subprocess.call(args, cwd=opts.chromium_dir, env=env) | 184 ret = subprocess.call(args, cwd=opts.chromium_dir, env=env) |
| 187 if ret == 0: | 185 if ret == 0: |
| 188 with open(flag_file, 'wb') as f: | 186 with open(flag_file, 'wb') as f: |
| 189 f.write(flag_file_content) | 187 f.write(flag_file_content) |
| 190 | 188 |
| 191 return ret | 189 return ret |
| 192 | 190 |
| 193 | 191 |
| 194 if __name__ == '__main__': | 192 if __name__ == '__main__': |
| 195 sys.exit(main()) | 193 sys.exit(main()) |
| OLD | NEW |
