Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2479533002: Cleanup warnings configs and enable more for Android ARM64 (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Cleanup warnings configs and enable more for Android ARM64 This will enable more warnings for Android ARM64 build. The main purpose is to clean up clutter in the warnings config. BUG=webrtc:6653 NOTRY=True Committed: https://crrev.com/496c64c0fa312454dca162bdff2e90e9618447da Cr-Commit-Position: refs/heads/master@{#14917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -39 lines) Patch
M webrtc/BUILD.gn View 1 chunk +14 lines, -22 lines 0 comments Download
M webrtc/build/common.gypi View 1 chunk +7 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kjellander_webrtc
Nice to get this cleaned up. I assume a newer NDK made the previous problem ...
4 years, 1 month ago (2016-11-03 13:52:44 UTC) #3
phoglund
Nice! lgtm
4 years, 1 month ago (2016-11-03 14:03:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2479533002/1
4 years, 1 month ago (2016-11-03 14:55:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 14:57:38 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 14:57:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/496c64c0fa312454dca162bdff2e90e9618447da
Cr-Commit-Position: refs/heads/master@{#14917}

Powered by Google App Engine
This is Rietveld 408576698