Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: webrtc/BUILD.gn

Issue 2479533002: Cleanup warnings configs and enable more for Android ARM64 (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/build/common.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/BUILD.gn
diff --git a/webrtc/BUILD.gn b/webrtc/BUILD.gn
index 0dd61bbb8601d0087dcb0e40d960565d9bdc9310..d1f52b32fe96169c82938cc965fe59ae54daafe1 100644
--- a/webrtc/BUILD.gn
+++ b/webrtc/BUILD.gn
@@ -152,29 +152,21 @@ config("common_config") {
]
} else {
if (is_posix) {
- # -Wextra is currently disabled in Chromium"s common.gypi. Enable
- # for targets that can handle it. For Android/arm64 right now
- # there will be an "enumeral and non-enumeral type in conditional
- # expression" warning in android_tools/ndk_experimental"s version
- # of stlport.
- # See: https://code.google.com/p/chromium/issues/detail?id=379699
- if (current_cpu != "arm64" || !is_android) {
- cflags = [
- "-Wextra",
-
- # We need to repeat some flags from Chromium"s common.gypi
- # here that get overridden by -Wextra.
- "-Wno-unused-parameter",
- "-Wno-missing-field-initializers",
- "-Wno-strict-overflow",
- ]
- cflags_cc = [
- "-Wnon-virtual-dtor",
+ # Enable more warnings: -Wextra is currently disabled in Chromium.
+ cflags = [
+ "-Wextra",
- # This is enabled for clang; enable for gcc as well.
- "-Woverloaded-virtual",
- ]
- }
+ # Repeat some flags that get overridden by -Wextra.
+ "-Wno-unused-parameter",
+ "-Wno-missing-field-initializers",
+ "-Wno-strict-overflow",
+ ]
+ cflags_cc = [
+ "-Wnon-virtual-dtor",
+
+ # This is enabled for clang; enable for gcc as well.
+ "-Woverloaded-virtual",
+ ]
}
if (is_clang) {
« no previous file with comments | « no previous file | webrtc/build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698