Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: webrtc/build/common.gypi

Issue 2479533002: Cleanup warnings configs and enable more for Android ARM64 (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 # This file contains common settings for building WebRTC components. 9 # This file contains common settings for building WebRTC components.
10 10
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 'includes': [ 313 'includes': [
314 # Rules for excluding e.g. foo_win.cc from the build on non-Windows. 314 # Rules for excluding e.g. foo_win.cc from the build on non-Windows.
315 'filename_rules.gypi', 315 'filename_rules.gypi',
316 ], 316 ],
317 # Include the top-level dir so the WebRTC code can use full paths. 317 # Include the top-level dir so the WebRTC code can use full paths.
318 'include_dirs': [ 318 'include_dirs': [
319 '../..', 319 '../..',
320 ], 320 ],
321 'conditions': [ 321 'conditions': [
322 ['os_posix==1', { 322 ['os_posix==1', {
323 'conditions': [ 323 # Enable more warnings: -Wextra is currently disabled in Chromium.
324 # -Wextra is currently disabled in Chromium's common.gypi. Enable 324 'cflags': [
325 # for targets that can handle it. For Android/arm64 right now 325 '-Wextra',
326 # there will be an 'enumeral and non-enumeral type in conditional 326 # Repeat some flags that get overridden by -Wextra.
327 # expression' warning in android_tools/ndk_experimental's version 327 '-Wno-unused-parameter',
328 # of stlport. 328 '-Wno-missing-field-initializers',
329 # See: https://code.google.com/p/chromium/issues/detail?id=379699 329 '-Wno-strict-overflow',
330 ['target_arch!="arm64" or OS!="android"', {
331 'cflags': [
332 '-Wextra',
333 # We need to repeat some flags from Chromium's common.gypi
334 # here that get overridden by -Wextra.
335 '-Wno-unused-parameter',
336 '-Wno-missing-field-initializers',
337 '-Wno-strict-overflow',
338 ],
339 }],
340 ], 330 ],
341 'cflags_cc': [ 331 'cflags_cc': [
342 '-Wnon-virtual-dtor', 332 '-Wnon-virtual-dtor',
343 # This is enabled for clang; enable for gcc as well. 333 # This is enabled for clang; enable for gcc as well.
344 '-Woverloaded-virtual', 334 '-Woverloaded-virtual',
345 ], 335 ],
346 }], 336 }],
347 ['clang==1', { 337 ['clang==1', {
348 'cflags': [ 338 'cflags': [
349 '-Wimplicit-fallthrough', 339 '-Wimplicit-fallthrough',
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 }], 585 }],
596 ['OS=="freebsd"', { 586 ['OS=="freebsd"', {
597 'defines': [ 587 'defines': [
598 'FREEBSD', 588 'FREEBSD',
599 ], 589 ],
600 }], 590 }],
601 ], 591 ],
602 }, 592 },
603 }, # target_defaults 593 }, # target_defaults
604 } 594 }
OLDNEW
« no previous file with comments | « webrtc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698