Update VideoFrameBuffer-related methods to not use references to scoped_refptr.

Update VideoFrameBuffer-related methods to not use references to scoped_refptr.

Chrome coding standard now discourages use of references to smart
pointers. This cl updates some recent methods to the new conventions.

BUG=webrtc:6672
Committed: https://crrev.com/e3fe4a7c2d4abd2dfde575b8e42c635f98703b9e
Cr-Commit-Position: refs/heads/master@{#15028}

[nisse-webrtc, 2016-11-07 15:33:05]

nisse@webrtc.org changed reviewers:
+ magjed@webrtc.org, stefan@webrtc.org

[nisse-webrtc, 2016-11-07 15:33:06]

This allows callers of these methods to stop using scoped_refptr arguments too. 

In particular, I'd like to change the VPMSimpleSpatialResampler::ResampleFrame
method to take a const VideoFrameBuffer& as input argument, instead of const
VideoFrame& or scoped_refptr<VideoFrameBuffer>.

I also change VideoFrame::video_frame_buffer() to return a scoped_refptr by
value; using a reference there was needed to make the IsMutable hack work, but
that was deleted a while ago. I hope this is fully backwards compatible, I'll
let the Chrome trybots test it.

[magjed_webrtc, 2016-11-09 09:54:45]

lgtm

https://codereview.webrtc.org/2477233004/diff/1/webrtc/common_video/include/v...
File webrtc/common_video/include/video_frame_buffer.h (right):

https://codereview.webrtc.org/2477233004/diff/1/webrtc/common_video/include/v...
webrtc/common_video/include/video_frame_buffer.h:139: static
rtc::scoped_refptr<VideoFrameBuffer> Rotate(
I think we check rotation before calling this method in every place, so I would
be happy to change this function to:
static rtc::scoped_refptr<I420Buffer> Rotate(
    const VideoFrameBuffer& src,
    VideoRotation rotation);
and leave the responsibility to the caller to not call this for zero rotation if
they want to optimize their code.
I'll leave the decision up to you.

[stefan-webrtc, 2016-11-09 17:54:55]

lgtm, but check the try failures

[nisse-webrtc, 2016-11-10 14:10:20]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-11-10 14:10:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 14:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 14:18:34]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/16053)

[nisse-webrtc, 2016-11-10 15:19:54]

https://codereview.webrtc.org/2477233004/diff/20001/webrtc/common_video/i420_...
File webrtc/common_video/i420_video_frame_unittest.cc (right):

https://codereview.webrtc.org/2477233004/diff/20001/webrtc/common_video/i420_...
webrtc/common_video/i420_video_frame_unittest.cc:157:
I420Buffer::Copy(*rtc::scoped_refptr<VideoFrameBuffer>(
This was a bit subtle. Just creating a temporary RefCountedObject seems to leak
that object. Constructing a temporary scoped_refptr to point to it hopefully
fixes that.

To make this call nicer, should I add a I420Buffer::Copy that takes raw yuvdata
as argument?

[nisse-webrtc, 2016-11-10 16:02:13]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-11-10 16:02:14]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2477233004/#ps20001 (title:
"Fix memory leak.")

[commit-bot: I haz the power, 2016-11-10 16:02:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 16:44:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 16:44:54]

Description was changed from

==========
Update VideoFrameBuffer-related methods to not use references to scoped_refptr.

Chrome coding standard now discourages use of references to smart
pointers. This cl updates some recent methods to the new conventions.

BUG=webrtc:6672
==========

to

==========
Update VideoFrameBuffer-related methods to not use references to scoped_refptr.

Chrome coding standard now discourages use of references to smart
pointers. This cl updates some recent methods to the new conventions.

BUG=webrtc:6672

Committed: https://crrev.com/e3fe4a7c2d4abd2dfde575b8e42c635f98703b9e
Cr-Commit-Position: refs/heads/master@{#15028}
==========

[commit-bot: I haz the power, 2016-11-10 16:44:56]

Patchset 2 (id:??) landed as
https://crrev.com/e3fe4a7c2d4abd2dfde575b8e42c635f98703b9e
Cr-Commit-Position: refs/heads/master@{#15028}