webrtc/modules/video_processing/spatial_resampler.cc - Issue 2477233004: Update VideoFrameBuffer-related methods to not use references to scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_processing/spatial_resampler.cc

Issue 2477233004: Update VideoFrameBuffer-related methods to not use references to scoped_refptr. (Closed)

Patch Set: Fix memory leak. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_processing/spatial_resampler.cc

diff --git a/webrtc/modules/video_processing/spatial_resampler.cc b/webrtc/modules/video_processing/spatial_resampler.cc

index 7c4aae20888d104c53c1989dac1061d72330635d..4d98605b2cc313fe1554519ed209582f77b32b90 100644

--- a/webrtc/modules/video_processing/spatial_resampler.cc

+++ b/webrtc/modules/video_processing/spatial_resampler.cc

@@ -56,7 +56,7 @@ int32_t VPMSimpleSpatialResampler::ResampleFrame(const VideoFrame& inFrame,

rtc::scoped_refptr<I420Buffer> scaled_buffer(

buffer_pool_.CreateBuffer(target_width_, target_height_));

- scaled_buffer->CropAndScaleFrom(inFrame.video_frame_buffer());

+ scaled_buffer->CropAndScaleFrom(*inFrame.video_frame_buffer());

*outFrame = VideoFrame(scaled_buffer,

inFrame.timestamp(),