webrtc/modules/video_coding/utility/quality_scaler.cc - Issue 2477233004: Update VideoFrameBuffer-related methods to not use references to scoped_refptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler.cc

Issue 2477233004: Update VideoFrameBuffer-related methods to not use references to scoped_refptr. (Closed)

Patch Set: Fix memory leak. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/utility/quality_scaler.cc

diff --git a/webrtc/modules/video_coding/utility/quality_scaler.cc b/webrtc/modules/video_coding/utility/quality_scaler.cc

index 59bc60596609f94fa56fe2eca88a510b431ffa02..0f63edca7d126d520fff5fd28eb39a8adf8ca66c 100644

--- a/webrtc/modules/video_coding/utility/quality_scaler.cc

+++ b/webrtc/modules/video_coding/utility/quality_scaler.cc

@@ -187,7 +187,7 @@ rtc::scoped_refptr<VideoFrameBuffer> QualityScaler::GetScaledBuffer(

rtc::scoped_refptr<I420Buffer> scaled_buffer =

pool_.CreateBuffer(res.width, res.height);

- scaled_buffer->ScaleFrom(frame);

+ scaled_buffer->ScaleFrom(*frame);

return scaled_buffer;

}