Use InstallDetails in installer_util.

Use InstallDetails in installer_util.

This change removes the following functionality in install_util that is
now performed once during startup in chrome_elf or setup.exe:

- ChannelInfo::GetChannelName
- InstallUtil::IsPerUserInstall
- InstallUtil::IsMultiInstall
- InstallUtil::IsChromeSxSProcess

The latter three functions now simply return the values held in the
process's InstallDetails instance, which is valid in both chrome and
setup. The same is true for GoogleUpdateSettings::GetChromeChannel and
GoogleUpdateSettings::GetChromeChannelAndModifiers.

Finally, the CHROME_PROBED_PROGRAM_FILES_PATH environment variable hack
to make IsPerUserInstall work in sandboxed procs has been removed, as
SHGetFolderPath is no longer used to determine whether or not Chrome is
running from within C:\Program Files{, (x86)}.

BUG=373987
Review-Url: https://codereview.chromium.org/2476573004
Cr-Commit-Position: refs/heads/master@{#452431}
Committed: https://chromium.googlesource.com/chromium/src/+/4cd293b2e7387f6085c1b188aea86bd744fd9f69

[grt (UTC plus 2), 2016-11-04 10:43:07]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 10:43:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 11:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 11:35:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[grt (UTC plus 2), 2016-11-04 12:32:35]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 12:32:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 12:51:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 12:51:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[grt (UTC plus 2), 2016-11-04 13:06:04]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 13:06:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 13:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 13:28:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[grt (UTC plus 2), 2016-11-04 14:05:35]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 14:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 15:53:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 15:53:20]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[grt (UTC plus 2), 2016-11-08 13:06:56]

Description was changed from

==========
Use InstallDetails in installer_util.

This change removes the following functionality in install_util that is
now performed once during startup in chrome_elf or setup.exe:

- ChannelInfo::GetChannelName
- InstallUtil::IsPerUserInstall
- InstallUtil::IsMultiInstall
- InstallUtil::IsChromeSxSProcess

The latter three functions now simply return the values held in the
process's InstallDetails instance, which is valid in both chrome and
setup. The same is true for GoogleUpdateSettings::GetChromeChannel and
GoogleUpdateSettings::GetChromeChannelAndModifiers.

The remainder of the CL is cleanup now that the path to the current
executable is no longer needed for IsPerUserInstall or IsMultiInstall.

It also introduces a Google Test test listener for use by executables
that need to run tests using various InstallDetails configurations. A
helper function can be used by a test to install a particular
InstallDetails instance that will automagically be cleaned up at the end
of the test, test case, or test program.

Finally, the CHROME_PROBED_PROGRAM_FILES_PATH environment variable hack
to make IsPerUserInstall work in sandboxed procs has been removed, as
SHGetFolderPath is no longer used to determine whether or not Chrome is
running from within C:\Program Files{, (x86)}.

BUG=373987
==========

to

==========
Use InstallDetails in installer_util.

This change removes the following functionality in install_util that is
now performed once during startup in chrome_elf or setup.exe:

- ChannelInfo::GetChannelName
- InstallUtil::IsPerUserInstall
- InstallUtil::IsMultiInstall
- InstallUtil::IsChromeSxSProcess

The latter three functions now simply return the values held in the
process's InstallDetails instance, which is valid in both chrome and
setup. The same is true for GoogleUpdateSettings::GetChromeChannel and
GoogleUpdateSettings::GetChromeChannelAndModifiers.

It also introduces a ScopedInstallDetails class for use by tests that
need to run using various InstallDetails configurations.

Finally, the CHROME_PROBED_PROGRAM_FILES_PATH environment variable hack
to make IsPerUserInstall work in sandboxed procs has been removed, as
SHGetFolderPath is no longer used to determine whether or not Chrome is
running from within C:\Program Files{, (x86)}.

BUG=373987
==========

[grt (UTC plus 2), 2016-11-08 13:07:10]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 13:07:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2016-11-08 14:12:44]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:13:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:02:39]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2017-01-03 18:03:09]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 18:03:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 19:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 19:27:56]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2017-01-06 16:03:33]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 16:04:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 17:29:49]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2017-01-10 13:33:43]

Patchset #8 (id:140001) has been deleted

[grt (UTC plus 2), 2017-01-10 13:33:53]

Patchset #8 (id:160001) has been deleted

[grt (UTC plus 2), 2017-02-13 13:44:30]

Description was changed from

==========
Use InstallDetails in installer_util.

This change removes the following functionality in install_util that is
now performed once during startup in chrome_elf or setup.exe:

- ChannelInfo::GetChannelName
- InstallUtil::IsPerUserInstall
- InstallUtil::IsMultiInstall
- InstallUtil::IsChromeSxSProcess

The latter three functions now simply return the values held in the
process's InstallDetails instance, which is valid in both chrome and
setup. The same is true for GoogleUpdateSettings::GetChromeChannel and
GoogleUpdateSettings::GetChromeChannelAndModifiers.

It also introduces a ScopedInstallDetails class for use by tests that
need to run using various InstallDetails configurations.

Finally, the CHROME_PROBED_PROGRAM_FILES_PATH environment variable hack
to make IsPerUserInstall work in sandboxed procs has been removed, as
SHGetFolderPath is no longer used to determine whether or not Chrome is
running from within C:\Program Files{, (x86)}.

BUG=373987
==========

to

==========
Use InstallDetails in installer_util.

This change removes the following functionality in install_util that is
now performed once during startup in chrome_elf or setup.exe:

- ChannelInfo::GetChannelName
- InstallUtil::IsPerUserInstall
- InstallUtil::IsMultiInstall
- InstallUtil::IsChromeSxSProcess

The latter three functions now simply return the values held in the
process's InstallDetails instance, which is valid in both chrome and
setup. The same is true for GoogleUpdateSettings::GetChromeChannel and
GoogleUpdateSettings::GetChromeChannelAndModifiers.

Finally, the CHROME_PROBED_PROGRAM_FILES_PATH environment variable hack
to make IsPerUserInstall work in sandboxed procs has been removed, as
SHGetFolderPath is no longer used to determine whether or not Chrome is
running from within C:\Program Files{, (x86)}.

BUG=373987
==========

[grt (UTC plus 2), 2017-02-14 12:03:08]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 12:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-02-14 12:03:36]

Patchset #8 (id:180001) has been deleted

[grt (UTC plus 2), 2017-02-14 12:13:35]

grt@chromium.org changed reviewers:
+ gab@chromium.org

[grt (UTC plus 2), 2017-02-14 12:13:36]

Hiya, Gab. Do you have cycles for this?

[commit-bot: I haz the power, 2017-02-14 12:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 12:35:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[grt (UTC plus 2), 2017-02-14 12:41:48]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 12:42:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 13:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 13:13:22]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[grt (UTC plus 2), 2017-02-14 13:20:54]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 13:21:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 14:24:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 14:24:16]

Dry run: This issue passed the CQ dry run.

[gab, 2017-02-14 16:57:56]

lgtm w/ comments (and I now finally understand the purpose of install_static --
it's a great improvement!)

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/beacons_unittest.cc (left):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/beacons_unittest.cc:282: // Disabled for now since
InstallUtil::IsChromeSxSProcess makes this impossible.
Nice :)! Was there an associated bug that this resolves?

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/beacons_unittest.cc (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/beacons_unittest.cc:161: system_install_ =
(std::string(level) != "user");
Why not just strcmp?

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/beacons_unittest.cc:273: #endif  // !GOOGLE_CHROME_BUILD
remove "!"

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/channel_info.cc (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/channel_info.cc:12: #include "base/strings/string_util.h"
rm these two and add string16.h

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/google_update_settings_unittest.cc (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/google_update_settings_unittest.cc:70:
install_static::ScopedInstallDetails details(install == SYSTEM_INSTALL);
This is unfortunate, would be much easier to read if
install_static::ScopedInstallDetails used enums instead of bools/ints :(

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/install_util.cc (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/install_util.cc:274: bool
InstallUtil::IsPerUserInstall(const base::FilePath& exe_path) {
/* exe_path */

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/install_util.h (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/install_util.h:88: // Files).
Deprecated comment + TODO to remove.

[grt (UTC plus 2), 2017-02-14 21:03:38]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:04:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-02-14 21:04:24]

Thanks. Comments addressed.

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/beacons_unittest.cc (left):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/beacons_unittest.cc:282: // Disabled for now since
InstallUtil::IsChromeSxSProcess makes this impossible.
On 2017/02/14 16:57:56, gab wrote:
> Nice :)! Was there an associated bug that this resolves?

Hooray for test seams! I can't find a bug for this, or for general
"IsChromeSxSProcess can't be mocked/faked".

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/channel_info.cc (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/channel_info.cc:12: #include "base/strings/string_util.h"
On 2017/02/14 16:57:56, gab wrote:
> rm these two and add string16.h

Removed! string16.h is included in channel_info.h, so leaving that out.

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/google_update_settings_unittest.cc (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/google_update_settings_unittest.cc:70:
install_static::ScopedInstallDetails details(install == SYSTEM_INSTALL);
On 2017/02/14 16:57:56, gab wrote:
> This is unfortunate, would be much easier to read if
> install_static::ScopedInstallDetails used enums instead of bools/ints :(

TODO added to scoped_install_details.h

(I hate to make you sad)

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/install_util.cc (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/install_util.cc:274: bool
InstallUtil::IsPerUserInstall(const base::FilePath& exe_path) {
On 2017/02/14 16:57:56, gab wrote:
> /* exe_path */

Done.

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
File chrome/installer/util/install_util.h (right):

https://codereview.chromium.org/2476573004/diff/220001/chrome/installer/util/...
chrome/installer/util/install_util.h:88: // Files).
On 2017/02/14 16:57:56, gab wrote:
> Deprecated comment + TODO to remove.

I'm on the fence as to whether or not this should stay around as a convenience
function for InstallDetails. TODO added.

[commit-bot: I haz the power, 2017-02-14 23:04:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 23:04:14]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2017-02-21 13:42:50]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 13:43:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 15:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 15:03:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[grt (UTC plus 2), 2017-02-21 21:29:16]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 21:30:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:38:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:38:53]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[grt (UTC plus 2), 2017-02-22 10:49:17]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-02-22 10:49:17]

The CQ bit was unchecked by grt@chromium.org

[grt (UTC plus 2), 2017-02-22 10:49:18]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2476573004/#ps300001
(title: "sync to position 451835")

[grt (UTC plus 2), 2017-02-22 10:49:18]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2017-02-22 10:49:18]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2476573004/#ps300001
(title: "sync to position 451835")

[commit-bot: I haz the power, 2017-02-22 10:49:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 10:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 10:56:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[grt (UTC plus 2), 2017-02-22 11:05:46]

grt@chromium.org changed reviewers:
+ pkasting@chromium.org

[grt (UTC plus 2), 2017-02-22 11:05:47]

+pkasting for chrome/browser/google/google_update_win_unittest.cc OWNERS stamp.
Thanks.

[Peter Kasting, 2017-02-23 01:33:12]

RS LGTM

[grt (UTC plus 2), 2017-02-23 07:15:55]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2017-02-23 07:16:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 08:12:21]

CQ is committing da patch.

Bot data: {"patchset_id": 300001, "attempt_start_ts": 1487834155468430,
"parent_rev": "9f9e4d69ac5649f7c5b842fbf271b9c2650aef44", "commit_rev":
"4cd293b2e7387f6085c1b188aea86bd744fd9f69"}

[commit-bot: I haz the power, 2017-02-23 08:12:57]

Description was changed from

==========
Use InstallDetails in installer_util.

This change removes the following functionality in install_util that is
now performed once during startup in chrome_elf or setup.exe:

- ChannelInfo::GetChannelName
- InstallUtil::IsPerUserInstall
- InstallUtil::IsMultiInstall
- InstallUtil::IsChromeSxSProcess

The latter three functions now simply return the values held in the
process's InstallDetails instance, which is valid in both chrome and
setup. The same is true for GoogleUpdateSettings::GetChromeChannel and
GoogleUpdateSettings::GetChromeChannelAndModifiers.

Finally, the CHROME_PROBED_PROGRAM_FILES_PATH environment variable hack
to make IsPerUserInstall work in sandboxed procs has been removed, as
SHGetFolderPath is no longer used to determine whether or not Chrome is
running from within C:\Program Files{, (x86)}.

BUG=373987
==========

to

==========
Use InstallDetails in installer_util.

This change removes the following functionality in install_util that is
now performed once during startup in chrome_elf or setup.exe:

- ChannelInfo::GetChannelName
- InstallUtil::IsPerUserInstall
- InstallUtil::IsMultiInstall
- InstallUtil::IsChromeSxSProcess

The latter three functions now simply return the values held in the
process's InstallDetails instance, which is valid in both chrome and
setup. The same is true for GoogleUpdateSettings::GetChromeChannel and
GoogleUpdateSettings::GetChromeChannelAndModifiers.

Finally, the CHROME_PROBED_PROGRAM_FILES_PATH environment variable hack
to make IsPerUserInstall work in sandboxed procs has been removed, as
SHGetFolderPath is no longer used to determine whether or not Chrome is
running from within C:\Program Files{, (x86)}.

BUG=373987

Review-Url: https://codereview.chromium.org/2476573004
Cr-Commit-Position: refs/heads/master@{#452431}
Committed:
https://chromium.googlesource.com/chromium/src/+/4cd293b2e7387f6085c1b188aea8...
==========

[commit-bot: I haz the power, 2017-02-23 08:12:59]

Committed patchset #13 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/4cd293b2e7387f6085c1b188aea8...