Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2279)

Unified Diff: chrome/install_static/test/scoped_install_details.h

Issue 2476573004: Use InstallDetails in installer_util. (Closed)
Patch Set: sync to position 451835 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/install_static/install_util_unittest.cc ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/install_static/test/scoped_install_details.h
diff --git a/chrome/install_static/test/scoped_install_details.h b/chrome/install_static/test/scoped_install_details.h
index 0fa0c28afd71f1cfa9e541d53ecffb37dd6c4349..1fc54cdbc1c2fc42b1560a4b1b5e4666236fb47f 100644
--- a/chrome/install_static/test/scoped_install_details.h
+++ b/chrome/install_static/test/scoped_install_details.h
@@ -20,6 +20,7 @@ class ScopedInstallDetails {
// Installs an InstallDetails instance that will report the install as being
// at |system_level| and of mode |install_mode_index| (an InstallConstantIndex
// value) of the current brand; see ../install_modes.h for details.
+ // TODO(grt): replace bool and int with more obvious types (e.g., enum).
explicit ScopedInstallDetails(bool system_level = false,
int install_mode_index = 0);
~ScopedInstallDetails();
« no previous file with comments | « chrome/install_static/install_util_unittest.cc ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698