Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: webrtc/modules/video_coding/include/video_coding_defines.h

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/include/video_coding_defines.h
diff --git a/webrtc/modules/video_coding/include/video_coding_defines.h b/webrtc/modules/video_coding/include/video_coding_defines.h
index 4657804896fbe9cfde6538caa9e0bbd61270041b..6d9846f8e9942c795f3a264fc792b17c3dcfbafd 100644
--- a/webrtc/modules/video_coding/include/video_coding_defines.h
+++ b/webrtc/modules/video_coding/include/video_coding_defines.h
@@ -114,11 +114,11 @@ class VCMDecoderTimingCallback {
// and the rates sent the last second is returned to the VCM.
class VCMProtectionCallback {
public:
- virtual int ProtectionRequest(const FecProtectionParams* delta_params,
- const FecProtectionParams* key_params,
- uint32_t* sent_video_rate_bps,
- uint32_t* sent_nack_rate_bps,
- uint32_t* sent_fec_rate_bps) = 0;
+ virtual void ProtectionRequest(const FecProtectionParams& delta_params,
danilchap 2016/10/28 10:16:41 changing this interface will break dependent proje
brandtr 2016/10/28 11:06:10 I see. I'll leave it unchanged for now.
+ const FecProtectionParams& key_params,
+ uint32_t* sent_video_rate_bps,
+ uint32_t* sent_nack_rate_bps,
+ uint32_t* sent_fec_rate_bps) = 0;
protected:
virtual ~VCMProtectionCallback() {}

Powered by Google App Engine
This is Rietveld 408576698