webrtc/modules/video_coding/protection_bitrate_calculator.cc - Issue 2455963003: Simplify SetFecParameters signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/protection_bitrate_calculator.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)

Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/protection_bitrate_calculator.cc

diff --git a/webrtc/modules/video_coding/protection_bitrate_calculator.cc b/webrtc/modules/video_coding/protection_bitrate_calculator.cc

index 411ed1a95ca57838792f0b73711e31ea3d5cd557..90ab5d37ce7f41cf64b8219ecca2ffc611398f29 100644

--- a/webrtc/modules/video_coding/protection_bitrate_calculator.cc

+++ b/webrtc/modules/video_coding/protection_bitrate_calculator.cc

@@ -130,7 +130,7 @@ uint32_t ProtectionBitrateCalculator::SetTargetRates(

// TODO(Marco): Pass FEC protection values per layer.

protection_callback_->ProtectionRequest(

- &delta_fec_params, &key_fec_params, &sent_video_rate_bps,

+ delta_fec_params, key_fec_params, &sent_video_rate_bps,

&sent_nack_rate_bps, &sent_fec_rate_bps);

uint32_t sent_total_rate_bps =