webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc - Issue 2455963003: Simplify SetFecParameters signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)

Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

index 2a2bf0df4b227a2ff9e02083ef4ee48324108d79..0094bd188aba75ab2eab6d7a49be9533d8497745 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

@@ -794,9 +794,9 @@ void ModuleRtpRtcpImpl::SetUlpfecConfig(int red_payload_type,

rtp_sender_.SetUlpfecConfig(red_payload_type, ulpfec_payload_type);

}

-int32_t ModuleRtpRtcpImpl::SetFecParameters(

- const FecProtectionParams* delta_params,

- const FecProtectionParams* key_params) {

+bool ModuleRtpRtcpImpl::SetFecParameters(

+ const FecProtectionParams& delta_params,

+ const FecProtectionParams& key_params) {

return rtp_sender_.SetFecParameters(delta_params, key_params);

}