webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h - Issue 2455963003: Simplify SetFecParameters signature.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

Issue 2455963003: Simplify SetFecParameters signature. (Closed)

Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

index f055bbe0012157a88d13099fbec2c9d616abf6d6..8cd47ed280d8af46d325e36e8ca38f3ba9cf993c 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

@@ -279,8 +279,8 @@ class ModuleRtpRtcpImpl : public RtpRtcp, public RTCPReceiver::ModuleRtpRtcp {

void SetUlpfecConfig(int red_payload_type, int ulpfec_payload_type) override;

- int32_t SetFecParameters(const FecProtectionParams* delta_params,

- const FecProtectionParams* key_params) override;

+ bool SetFecParameters(const FecProtectionParams& delta_params,

+ const FecProtectionParams& key_params) override;

bool LastReceivedNTP(uint32_t* NTPsecs,

uint32_t* NTPfrac,