Chromium Code Reviews

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 2455963003: Simplify SetFecParameters signature. (Closed)
Patch Set: Return type int32_t replaced by bool and void. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 776 matching lines...)
787 const uint8_t picture_id) { 787 const uint8_t picture_id) {
788 return rtcp_sender_.SendRTCP( 788 return rtcp_sender_.SendRTCP(
789 GetFeedbackState(), kRtcpSli, 0, 0, false, picture_id); 789 GetFeedbackState(), kRtcpSli, 0, 0, false, picture_id);
790 } 790 }
791 791
792 void ModuleRtpRtcpImpl::SetUlpfecConfig(int red_payload_type, 792 void ModuleRtpRtcpImpl::SetUlpfecConfig(int red_payload_type,
793 int ulpfec_payload_type) { 793 int ulpfec_payload_type) {
794 rtp_sender_.SetUlpfecConfig(red_payload_type, ulpfec_payload_type); 794 rtp_sender_.SetUlpfecConfig(red_payload_type, ulpfec_payload_type);
795 } 795 }
796 796
797 int32_t ModuleRtpRtcpImpl::SetFecParameters( 797 bool ModuleRtpRtcpImpl::SetFecParameters(
798 const FecProtectionParams* delta_params, 798 const FecProtectionParams& delta_params,
799 const FecProtectionParams* key_params) { 799 const FecProtectionParams& key_params) {
800 return rtp_sender_.SetFecParameters(delta_params, key_params); 800 return rtp_sender_.SetFecParameters(delta_params, key_params);
801 } 801 }
802 802
803 void ModuleRtpRtcpImpl::SetRemoteSSRC(const uint32_t ssrc) { 803 void ModuleRtpRtcpImpl::SetRemoteSSRC(const uint32_t ssrc) {
804 // Inform about the incoming SSRC. 804 // Inform about the incoming SSRC.
805 rtcp_sender_.SetRemoteSSRC(ssrc); 805 rtcp_sender_.SetRemoteSSRC(ssrc);
806 rtcp_receiver_.SetRemoteSSRC(ssrc); 806 rtcp_receiver_.SetRemoteSSRC(ssrc);
807 807
808 // Check for a SSRC collision. 808 // Check for a SSRC collision.
809 if (rtp_sender_.SSRC() == ssrc && !collision_detected_) { 809 if (rtp_sender_.SSRC() == ssrc && !collision_detected_) {
(...skipping 115 matching lines...)
925 void ModuleRtpRtcpImpl::RegisterSendChannelRtpStatisticsCallback( 925 void ModuleRtpRtcpImpl::RegisterSendChannelRtpStatisticsCallback(
926 StreamDataCountersCallback* callback) { 926 StreamDataCountersCallback* callback) {
927 rtp_sender_.RegisterRtpStatisticsCallback(callback); 927 rtp_sender_.RegisterRtpStatisticsCallback(callback);
928 } 928 }
929 929
930 StreamDataCountersCallback* 930 StreamDataCountersCallback*
931 ModuleRtpRtcpImpl::GetSendChannelRtpStatisticsCallback() const { 931 ModuleRtpRtcpImpl::GetSendChannelRtpStatisticsCallback() const {
932 return rtp_sender_.GetRtpStatisticsCallback(); 932 return rtp_sender_.GetRtpStatisticsCallback();
933 } 933 }
934 } // namespace webrtc 934 } // namespace webrtc
OLDNEW

Powered by Google App Engine