Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2433293003: Revert of Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. (Closed)

Created:
4 years, 2 months ago by nisse-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. (patchset #5 id:80001 of https://codereview.webrtc.org/2334683002/ ) Reason for revert: This was a workaround to help Chrome wire up the googNoiseReduction constraint. However, it was fixed in a different way in Chrome, and this hack is not actually needed. Original issue's description: > Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. > > BUG=chromium:645907 > > Committed: https://crrev.com/0d14c6abba19295725519ce38105688ae0a62513 > Cr-Commit-Position: refs/heads/master@{#14219} TBR=pbos@webrtc.org,hta@webrtc.org,perkj@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:645907 Committed: https://crrev.com/66712b024f1e3490c1aecee431e0897c961c54fe Cr-Commit-Position: refs/heads/master@{#14729}

Patch Set 1 #

Patch Set 2 : Solved patch conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -52 lines) Patch
M webrtc/api/videocapturertracksource.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/api/videocapturertracksource_unittest.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
M webrtc/media/base/fakevideocapturer.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
nisse-webrtc
Created Revert of Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource.
4 years, 2 months ago (2016-10-20 08:04:38 UTC) #1
nisse-webrtc
It turned out we didn't need this hack, right?
4 years, 2 months ago (2016-10-20 08:47:57 UTC) #2
perkj_webrtc
On 2016/10/20 08:47:57, nisse-webrtc wrote: > It turned out we didn't need this hack, right? ...
4 years, 2 months ago (2016-10-20 13:44:25 UTC) #3
pbos-webrtc
lgtm
4 years, 2 months ago (2016-10-20 19:17:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2433293003/110001
4 years, 2 months ago (2016-10-21 06:32:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_compile_mips_dbg on ...
4 years, 2 months ago (2016-10-21 08:33:25 UTC) #8
hta-webrtc
lgtm provided the chrome-test bots are green. Some of the calls that were called in ...
4 years, 2 months ago (2016-10-21 08:57:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2433293003/110001
4 years, 2 months ago (2016-10-21 09:57:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_rel on ...
4 years, 2 months ago (2016-10-21 11:57:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2433293003/110001
4 years, 1 month ago (2016-10-24 06:35:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:110001)
4 years, 1 month ago (2016-10-24 07:22:35 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 07:22:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66712b024f1e3490c1aecee431e0897c961c54fe
Cr-Commit-Position: refs/heads/master@{#14729}

Powered by Google App Engine
This is Rietveld 408576698