Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: webrtc/media/base/videocapturer.h

Issue 2433293003: Revert of Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. (Closed)
Patch Set: Solved patch conflicts. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/fakevideocapturer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2010 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 CaptureState capture_state() const { 133 CaptureState capture_state() const {
134 return capture_state_; 134 return capture_state_;
135 } 135 }
136 136
137 virtual bool apply_rotation() { return apply_rotation_; } 137 virtual bool apply_rotation() { return apply_rotation_; }
138 138
139 // Returns true if the capturer is screencasting. This can be used to 139 // Returns true if the capturer is screencasting. This can be used to
140 // implement screencast specific behavior. 140 // implement screencast specific behavior.
141 virtual bool IsScreencast() const = 0; 141 virtual bool IsScreencast() const = 0;
142 142
143 // Indicates that the encoder should denoise video before encoding
144 // it, wired up to VideoCapturerTrackSource::needs_denoising. If it
145 // is not set, the default configuration is used which is different
146 // depending on video codec.
147 // TODO(nisse): This is a workaround needed to fix
148 // https://bugs.chromium.org/p/chromium/issues/detail?id=645907.
149 // Chrome should migrate to implement VideoTrackSourceInterface
150 // directly, and then this method is no longer needed.
151 virtual rtc::Optional<bool> NeedsDenoising() const {
152 return rtc::Optional<bool>();
153 }
154
155 // Caps the VideoCapturer's format according to max_format. It can e.g. be 143 // Caps the VideoCapturer's format according to max_format. It can e.g. be
156 // used to prevent cameras from capturing at a resolution or framerate that 144 // used to prevent cameras from capturing at a resolution or framerate that
157 // the capturer is capable of but not performing satisfactorily at. 145 // the capturer is capable of but not performing satisfactorily at.
158 // The capping is an upper bound for each component of the capturing format. 146 // The capping is an upper bound for each component of the capturing format.
159 // The fourcc component is ignored. 147 // The fourcc component is ignored.
160 void ConstrainSupportedFormats(const VideoFormat& max_format); 148 void ConstrainSupportedFormats(const VideoFormat& max_format);
161 149
162 void set_enable_camera_list(bool enable_camera_list) { 150 void set_enable_camera_list(bool enable_camera_list) {
163 enable_camera_list_ = enable_camera_list; 151 enable_camera_list_ = enable_camera_list;
164 } 152 }
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 bool apply_rotation_; 274 bool apply_rotation_;
287 275
288 // State for the timestamp translation. 276 // State for the timestamp translation.
289 rtc::TimestampAligner timestamp_aligner_; 277 rtc::TimestampAligner timestamp_aligner_;
290 RTC_DISALLOW_COPY_AND_ASSIGN(VideoCapturer); 278 RTC_DISALLOW_COPY_AND_ASSIGN(VideoCapturer);
291 }; 279 };
292 280
293 } // namespace cricket 281 } // namespace cricket
294 282
295 #endif // WEBRTC_MEDIA_BASE_VIDEOCAPTURER_H_ 283 #endif // WEBRTC_MEDIA_BASE_VIDEOCAPTURER_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/fakevideocapturer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698