Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: webrtc/api/videocapturertracksource_unittest.cc

Issue 2433293003: Revert of Add method cricket::VideoCapturer::NeedsDenoising, use in VideoCapturerTrackSource. (Closed)
Patch Set: Solved patch conflicts. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/videocapturertracksource.cc ('k') | webrtc/media/base/fakevideocapturer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/videocapturertracksource_unittest.cc
diff --git a/webrtc/api/videocapturertracksource_unittest.cc b/webrtc/api/videocapturertracksource_unittest.cc
index d8f4b0c761dc7837e31ce9d7bc39769df77ff449..67c249827bbd4113943041be9de1c87d06d45a89 100644
--- a/webrtc/api/videocapturertracksource_unittest.cc
+++ b/webrtc/api/videocapturertracksource_unittest.cc
@@ -444,35 +444,6 @@ TEST_F(VideoCapturerTrackSourceTest, ScreencastResolutionWithConstraint) {
EXPECT_EQ(30, format->framerate());
}
-TEST_F(VideoCapturerTrackSourceTest, DenoisingDefault) {
- CreateVideoCapturerSource();
- EXPECT_FALSE(source_->needs_denoising());
-}
-
-TEST_F(VideoCapturerTrackSourceTest, DenoisingConstraintOn) {
- FakeConstraints constraints;
- constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction, true);
- CreateVideoCapturerSource(&constraints);
- ASSERT_TRUE(source_->needs_denoising());
- EXPECT_TRUE(*source_->needs_denoising());
-}
-
-TEST_F(VideoCapturerTrackSourceTest, DenoisingCapturerOff) {
- capturer_->SetNeedsDenoising(rtc::Optional<bool>(false));
- CreateVideoCapturerSource();
- ASSERT_TRUE(source_->needs_denoising());
- EXPECT_FALSE(*source_->needs_denoising());
-}
-
-TEST_F(VideoCapturerTrackSourceTest, DenoisingConstraintOverridesCapturer) {
- capturer_->SetNeedsDenoising(rtc::Optional<bool>(false));
- FakeConstraints constraints;
- constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction, true);
- CreateVideoCapturerSource(&constraints);
- ASSERT_TRUE(source_->needs_denoising());
- EXPECT_TRUE(*source_->needs_denoising());
-}
-
TEST_F(VideoCapturerTrackSourceTest, MandatorySubOneFpsConstraints) {
FakeConstraints constraints;
constraints.AddMandatory(MediaConstraintsInterface::kMaxFrameRate, 0.5);
« no previous file with comments | « webrtc/api/videocapturertracksource.cc ('k') | webrtc/media/base/fakevideocapturer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698