Handle RTCCertificate::fromPEM returning nullptr, with a unit test.

Handle RTCCertificate::fromPEM returning nullptr, with a unit test.

BUG=148757, webrtc:6488
Committed: https://crrev.com/abfc7f7c3b7069377da6c31af0d4f8f48b9a892a
Cr-Commit-Position: refs/heads/master@{#427235}

[jbroman, 2016-10-18 18:44:05]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 18:47:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 19:59:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 19:59:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbroman, 2016-10-18 20:46:38]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org, hbos@chromium.org

[jbroman, 2016-10-18 20:46:39]

This is the Chromium/Blink side of https://codereview.webrtc.org/2424093002. The
added unit test currently fails, but should begin passing with the WebRTC change
(at least, it does for me locally).

[haraken, 2016-10-18 20:48:07]

LGTM

[hbos_chromium, 2016-10-19 14:40:26]

lgtm

[jbroman, 2016-10-21 17:37:34]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-10-21 17:37:44]

On 2016/10/19 at 14:40:26, hbos wrote:
> lgtm

WebRTC change has rolled, CQing.

[commit-bot: I haz the power, 2016-10-21 17:38:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 18:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 18:23:48]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbroman, 2016-10-21 21:44:38]

jbroman@chromium.org changed reviewers:
+ sky@chromium.org

[jbroman, 2016-10-21 21:44:39]

+sky for content/test/OWNERS (change is very similar to the change in
content/renderer/media/)

[sky, 2016-10-21 23:13:11]

https://codereview.chromium.org/2432493002/diff/1/content/test/test_blink_web...
File content/test/test_blink_web_unit_test_support.cc (right):

https://codereview.chromium.org/2432493002/diff/1/content/test/test_blink_web...
content/test/test_blink_web_unit_test_support.cc:338: return
base::MakeUnique<RTCCertificate>(certificate);
Is RTCCertificate and rtc::RTCCertificate different?

[jbroman, 2016-10-22 15:33:26]

https://codereview.chromium.org/2432493002/diff/1/content/test/test_blink_web...
File content/test/test_blink_web_unit_test_support.cc (right):

https://codereview.chromium.org/2432493002/diff/1/content/test/test_blink_web...
content/test/test_blink_web_unit_test_support.cc:338: return
base::MakeUnique<RTCCertificate>(certificate);
On 2016/10/21 at 23:13:11, sky wrote:
> Is RTCCertificate and rtc::RTCCertificate different?

Yes, the former is content::RTCCertificate (in content/renderer/media/, which
derives from blink::WebRTCCertificate) and the latter is rtc::RTCCertificate (in
third_party/webrtc/), which is what's held internally in
content::RTCCertificate.

[sky, 2016-10-24 15:34:10]

Ok, LGTM

[jbroman, 2016-10-24 21:17:32]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:33:02]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[jbroman, 2016-10-25 00:36:58]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:55:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-25 01:58:09]

Description was changed from

==========
Handle RTCCertificate::fromPEM returning nullptr, with a unit test.

BUG=148757,webrtc:6488
==========

to

==========
Handle RTCCertificate::fromPEM returning nullptr, with a unit test.

BUG=148757,webrtc:6488

Committed: https://crrev.com/abfc7f7c3b7069377da6c31af0d4f8f48b9a892a
Cr-Commit-Position: refs/heads/master@{#427235}
==========

[commit-bot: I haz the power, 2016-10-25 01:58:10]

Patchset 1 (id:??) landed as
https://crrev.com/abfc7f7c3b7069377da6c31af0d4f8f48b9a892a
Cr-Commit-Position: refs/heads/master@{#427235}