Return nullptr from RTCCertificate::FromPEM on failure.

Return nullptr from RTCCertificate::FromPEM on failure.

BUG=webrtc:6488
Committed: https://crrev.com/b9eaeba71f52939557b8abc5042902e50d5ccd2e
Cr-Commit-Position: refs/heads/master@{#14710}

[jbroman, 2016-10-17 17:52:29]

Description was changed from

==========
Return nullptr from RTCCertificate::FromPEM on failure.

BUG=6488
==========

to

==========
Return nullptr from RTCCertificate::FromPEM on failure.

BUG=webrtc:6488
==========

[jbroman, 2016-10-17 17:58:40]

jbroman@chromium.org changed reviewers:
+ henrikg@webrtc.org

[jbroman, 2016-10-17 17:58:41]

If this LGTY, I can modify Blink to handle nullptr being returned from this call
site.

Without some way of WebRTC signalling an error, Blink cannot fail gracefully
(short of implementing its own certificate format validation).

[Henrik Grunell WebRTC, 2016-10-18 08:23:52]

henrikg@webrtc.org changed reviewers:
+ hbos@webrtc.org

[Henrik Grunell WebRTC, 2016-10-18 08:23:52]

The change seems to make sense to me, but I don't know how this code is used.

+hbos who worked on this to take a look first.

[hbos, 2016-10-18 17:28:28]

lgtm.

Can you add me as a reviewer to the follow-ups that handle nullptr in Blink?

[jbroman, 2016-10-18 17:34:09]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-10-18 17:34:10]

Sure, will do.

[commit-bot: I haz the power, 2016-10-18 17:34:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-18 17:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:44:46]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9279)

[jbroman, 2016-10-18 17:48:33]

Ah, still needs an owner approval.

[Henrik Grunell WebRTC, 2016-10-19 08:09:43]

lgtm

[jbroman, 2016-10-19 13:32:14]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-19 13:32:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 15:32:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 15:32:53]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[jbroman, 2016-10-19 15:33:52]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-19 15:34:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 17:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 17:34:31]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[jbroman, 2016-10-19 19:41:32]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-19 19:41:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 21:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:42:02]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[jbroman, 2016-10-20 14:28:08]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-20 14:28:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-20 16:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:28:47]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[jbroman, 2016-10-20 16:42:31]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:42:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[hbos, 2016-10-20 17:01:06]

(If presubmit keeps timing out due to bot problems I'd consider landing with
NOTRY=True considering everything else is green and you do indeed have all the
LGTMs. But I'm a bit YOLO.)

[commit-bot: I haz the power, 2016-10-20 17:27:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-20 17:49:06]

Description was changed from

==========
Return nullptr from RTCCertificate::FromPEM on failure.

BUG=webrtc:6488
==========

to

==========
Return nullptr from RTCCertificate::FromPEM on failure.

BUG=webrtc:6488

Committed: https://crrev.com/b9eaeba71f52939557b8abc5042902e50d5ccd2e
Cr-Commit-Position: refs/heads/master@{#14710}
==========

[commit-bot: I haz the power, 2016-10-20 17:49:06]

Patchset 1 (id:??) landed as
https://crrev.com/b9eaeba71f52939557b8abc5042902e50d5ccd2e
Cr-Commit-Position: refs/heads/master@{#14710}