webrtc/base/rtccertificate.cc - Issue 2424093002: Return nullptr from RTCCertificate::FromPEM on failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/rtccertificate.cc

Issue 2424093002: Return nullptr from RTCCertificate::FromPEM on failure. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/rtccertificate.cc

diff --git a/webrtc/base/rtccertificate.cc b/webrtc/base/rtccertificate.cc

index 574bf75bf290bb2e84b5aa634a84b13b86786760..3b3b8c9e89fbcaec7b7889a9ab374ac41bf79812 100644

--- a/webrtc/base/rtccertificate.cc

+++ b/webrtc/base/rtccertificate.cc

@@ -54,6 +54,8 @@ scoped_refptr<RTCCertificate> RTCCertificate::FromPEM(

const RTCCertificatePEM& pem) {

std::unique_ptr<SSLIdentity> identity(SSLIdentity::FromPEMStrings(

pem.private_key(), pem.certificate()));

+ if (!identity)

+ return nullptr;

return new RefCountedObject<RTCCertificate>(identity.release());

}

« no previous file with comments | « webrtc/base/rtccertificate.h ('k') | webrtc/base/rtccertificate_unittest.cc » ('j') | no next file with comments »