Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: webrtc/base/rtccertificate_unittest.cc

Issue 2424093002: Return nullptr from RTCCertificate::FromPEM on failure. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/rtccertificate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2015 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 130
131 // To PEM. 131 // To PEM.
132 RTCCertificatePEM orig_pem = orig->ToPEM(); 132 RTCCertificatePEM orig_pem = orig->ToPEM();
133 // Clone from PEM. 133 // Clone from PEM.
134 scoped_refptr<RTCCertificate> clone = RTCCertificate::FromPEM(orig_pem); 134 scoped_refptr<RTCCertificate> clone = RTCCertificate::FromPEM(orig_pem);
135 EXPECT_TRUE(clone); 135 EXPECT_TRUE(clone);
136 EXPECT_TRUE(*orig == *clone); 136 EXPECT_TRUE(*orig == *clone);
137 EXPECT_EQ(orig->Expires(), clone->Expires()); 137 EXPECT_EQ(orig->Expires(), clone->Expires());
138 } 138 }
139 139
140 TEST_F(RTCCertificateTest, FromPEMWithInvalidPEM) {
141 RTCCertificatePEM pem("not a valid PEM", "not a valid PEM");
142 scoped_refptr<RTCCertificate> certificate = RTCCertificate::FromPEM(pem);
143 EXPECT_FALSE(certificate);
144 }
145
140 } // namespace rtc 146 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/rtccertificate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698