Add a placeholder stat for logging the estimated residual echo likelihood.

Add a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has landed.

BUG=webrtc:6525
Committed: https://crrev.com/8c63a82bf56cce8db03a6c1a24d7f1096e4ca0e2
Cr-Commit-Position: refs/heads/master@{#14721}

[ivoc, 2016-10-18 13:20:06]

Description was changed from

==========
This adds a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525
==========

to

==========
This adds a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525
==========

[ivoc, 2016-10-18 13:20:06]

ivoc@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[ivoc, 2016-10-18 13:30:59]

Description was changed from

==========
This adds a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525
==========

to

==========
Add a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525
==========

[ivoc, 2016-10-18 13:31:19]

Hi Fredrik, Please have a look at this CL to add a placeholder stat for the
residual echo detector to GetStats(). It is currently always set to zero, but
this will change soon when it is hooked up to the residual echo detector.

[the sun, 2016-10-19 18:27:06]

lgtm % comments

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/mediastreaminterfa...
File webrtc/api/mediastreaminterface.h (right):

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/mediastreaminterfa...
webrtc/api/mediastreaminterface.h:208: int echo_delay_std_ms;
While you're poking around, why isn't echo_delay_std_ms next to
echo_delay_media_ms?

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/mediastreaminterfa...
webrtc/api/mediastreaminterface.h:209: float residual_echo_likelihood = 0.0f;
Initialize all fields in the same way, please - in other words change the old
ones or add the new one to the initializer list.

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/statscollector.cc
File webrtc/api/statscollector.cc (right):

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/statscollector.cc#...
webrtc/api/statscollector.cc:127: if (residual_echo_likelihood >= 0.0f &&
residual_echo_likelihood <= 1.0f) {
Why the upper limit? The lower limit is only there to allow -1 to mean "unset".
No other range limiting for stats is done here. Let's keep it consistent.

https://codereview.webrtc.org/2431443003/diff/1/webrtc/media/base/mediachannel.h
File webrtc/media/base/mediachannel.h (right):

https://codereview.webrtc.org/2431443003/diff/1/webrtc/media/base/mediachanne...
webrtc/media/base/mediachannel.h:601: float residual_echo_likelihood = 0.0f;
Don't mix styles of intialization

[ivoc, 2016-10-20 14:28:12]

Thanks for the comments!

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/mediastreaminterfa...
File webrtc/api/mediastreaminterface.h (right):

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/mediastreaminterfa...
webrtc/api/mediastreaminterface.h:208: int echo_delay_std_ms;
On 2016/10/19 18:27:06, the sun wrote:
> While you're poking around, why isn't echo_delay_std_ms next to
> echo_delay_media_ms?

It is now.

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/mediastreaminterfa...
webrtc/api/mediastreaminterface.h:209: float residual_echo_likelihood = 0.0f;
On 2016/10/19 18:27:06, the sun wrote:
> Initialize all fields in the same way, please - in other words change the old
> ones or add the new one to the initializer list.

Done.

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/statscollector.cc
File webrtc/api/statscollector.cc (right):

https://codereview.webrtc.org/2431443003/diff/1/webrtc/api/statscollector.cc#...
webrtc/api/statscollector.cc:127: if (residual_echo_likelihood >= 0.0f &&
residual_echo_likelihood <= 1.0f) {
On 2016/10/19 18:27:06, the sun wrote:
> Why the upper limit? The lower limit is only there to allow -1 to mean
"unset".
> No other range limiting for stats is done here. Let's keep it consistent.

That's a good point, I thought that probabilities should not be higher than one,
but I guess it makes sense not to enforce it in case we want to move away from
probabilities at some point.

https://codereview.webrtc.org/2431443003/diff/1/webrtc/media/base/mediachannel.h
File webrtc/media/base/mediachannel.h (right):

https://codereview.webrtc.org/2431443003/diff/1/webrtc/media/base/mediachanne...
webrtc/media/base/mediachannel.h:601: float residual_echo_likelihood = 0.0f;
On 2016/10/19 18:27:06, the sun wrote:
> Don't mix styles of intialization

Done.

[ivoc, 2016-10-20 14:28:25]

The CQ bit was checked by ivoc@webrtc.org

[ivoc, 2016-10-20 14:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2431443003/#ps20001 (title:
"Fredrik's comments.")

[commit-bot: I haz the power, 2016-10-20 14:28:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-20 16:28:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 16:28:53]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_clang_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_compile_mips_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_compile_x86_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build
URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_arm on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_asan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_compile_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_gyp_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_msan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_tsan2 on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ivoc, 2016-10-21 07:31:34]

The CQ bit was checked by ivoc@webrtc.org

[commit-bot: I haz the power, 2016-10-21 07:31:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-21 09:32:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 09:32:14]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ivoc, 2016-10-21 11:08:02]

The CQ bit was checked by ivoc@webrtc.org

[commit-bot: I haz the power, 2016-10-21 11:08:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-21 11:10:05]

Description was changed from

==========
Add a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525
==========

to

==========
Add a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525
==========

[commit-bot: I haz the power, 2016-10-21 11:10:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 11:10:14]

Description was changed from

==========
Add a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525
==========

to

==========
Add a placeholder stat for logging the estimated residual echo likelihood.

The stat is currently always set to zero until the residual echo detector has
landed.

BUG=webrtc:6525

Committed: https://crrev.com/8c63a82bf56cce8db03a6c1a24d7f1096e4ca0e2
Cr-Commit-Position: refs/heads/master@{#14721}
==========

[commit-bot: I haz the power, 2016-10-21 11:10:15]

Patchset 2 (id:??) landed as
https://crrev.com/8c63a82bf56cce8db03a6c1a24d7f1096e4ca0e2
Cr-Commit-Position: refs/heads/master@{#14721}