Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: webrtc/media/engine/webrtcvoiceengine_unittest.cc

Issue 2431443003: Add a placeholder stat for logging the estimated residual echo likelihood. (Closed)
Patch Set: Fredrik's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2008 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2008 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 stats.codec_name = "codec_name_send"; 390 stats.codec_name = "codec_name_send";
391 stats.ext_seqnum = 789; 391 stats.ext_seqnum = 789;
392 stats.jitter_ms = 12; 392 stats.jitter_ms = 12;
393 stats.rtt_ms = 345; 393 stats.rtt_ms = 345;
394 stats.audio_level = 678; 394 stats.audio_level = 678;
395 stats.aec_quality_min = 9.01f; 395 stats.aec_quality_min = 9.01f;
396 stats.echo_delay_median_ms = 234; 396 stats.echo_delay_median_ms = 234;
397 stats.echo_delay_std_ms = 567; 397 stats.echo_delay_std_ms = 567;
398 stats.echo_return_loss = 890; 398 stats.echo_return_loss = 890;
399 stats.echo_return_loss_enhancement = 1234; 399 stats.echo_return_loss_enhancement = 1234;
400 stats.residual_echo_likelihood = 0.432f;
400 stats.typing_noise_detected = true; 401 stats.typing_noise_detected = true;
401 return stats; 402 return stats;
402 } 403 }
403 void SetAudioSendStreamStats() { 404 void SetAudioSendStreamStats() {
404 for (auto* s : call_.GetAudioSendStreams()) { 405 for (auto* s : call_.GetAudioSendStreams()) {
405 s->SetStats(GetAudioSendStreamStats()); 406 s->SetStats(GetAudioSendStreamStats());
406 } 407 }
407 } 408 }
408 void VerifyVoiceSenderInfo(const cricket::VoiceSenderInfo& info, 409 void VerifyVoiceSenderInfo(const cricket::VoiceSenderInfo& info,
409 bool is_sending) { 410 bool is_sending) {
410 const auto stats = GetAudioSendStreamStats(); 411 const auto stats = GetAudioSendStreamStats();
411 EXPECT_EQ(info.ssrc(), stats.local_ssrc); 412 EXPECT_EQ(info.ssrc(), stats.local_ssrc);
412 EXPECT_EQ(info.bytes_sent, stats.bytes_sent); 413 EXPECT_EQ(info.bytes_sent, stats.bytes_sent);
413 EXPECT_EQ(info.packets_sent, stats.packets_sent); 414 EXPECT_EQ(info.packets_sent, stats.packets_sent);
414 EXPECT_EQ(info.packets_lost, stats.packets_lost); 415 EXPECT_EQ(info.packets_lost, stats.packets_lost);
415 EXPECT_EQ(info.fraction_lost, stats.fraction_lost); 416 EXPECT_EQ(info.fraction_lost, stats.fraction_lost);
416 EXPECT_EQ(info.codec_name, stats.codec_name); 417 EXPECT_EQ(info.codec_name, stats.codec_name);
417 EXPECT_EQ(info.ext_seqnum, stats.ext_seqnum); 418 EXPECT_EQ(info.ext_seqnum, stats.ext_seqnum);
418 EXPECT_EQ(info.jitter_ms, stats.jitter_ms); 419 EXPECT_EQ(info.jitter_ms, stats.jitter_ms);
419 EXPECT_EQ(info.rtt_ms, stats.rtt_ms); 420 EXPECT_EQ(info.rtt_ms, stats.rtt_ms);
420 EXPECT_EQ(info.audio_level, stats.audio_level); 421 EXPECT_EQ(info.audio_level, stats.audio_level);
421 EXPECT_EQ(info.aec_quality_min, stats.aec_quality_min); 422 EXPECT_EQ(info.aec_quality_min, stats.aec_quality_min);
422 EXPECT_EQ(info.echo_delay_median_ms, stats.echo_delay_median_ms); 423 EXPECT_EQ(info.echo_delay_median_ms, stats.echo_delay_median_ms);
423 EXPECT_EQ(info.echo_delay_std_ms, stats.echo_delay_std_ms); 424 EXPECT_EQ(info.echo_delay_std_ms, stats.echo_delay_std_ms);
424 EXPECT_EQ(info.echo_return_loss, stats.echo_return_loss); 425 EXPECT_EQ(info.echo_return_loss, stats.echo_return_loss);
425 EXPECT_EQ(info.echo_return_loss_enhancement, 426 EXPECT_EQ(info.echo_return_loss_enhancement,
426 stats.echo_return_loss_enhancement); 427 stats.echo_return_loss_enhancement);
428 EXPECT_EQ(info.residual_echo_likelihood, stats.residual_echo_likelihood);
427 EXPECT_EQ(info.typing_noise_detected, 429 EXPECT_EQ(info.typing_noise_detected,
428 stats.typing_noise_detected && is_sending); 430 stats.typing_noise_detected && is_sending);
429 } 431 }
430 432
431 webrtc::AudioReceiveStream::Stats GetAudioReceiveStreamStats() const { 433 webrtc::AudioReceiveStream::Stats GetAudioReceiveStreamStats() const {
432 webrtc::AudioReceiveStream::Stats stats; 434 webrtc::AudioReceiveStream::Stats stats;
433 stats.remote_ssrc = 123; 435 stats.remote_ssrc = 123;
434 stats.bytes_rcvd = 456; 436 stats.bytes_rcvd = 456;
435 stats.packets_rcvd = 768; 437 stats.packets_rcvd = 768;
436 stats.packets_lost = 101; 438 stats.packets_lost = 101;
(...skipping 3079 matching lines...) Expand 10 before | Expand all | Expand 10 after
3516 nullptr, webrtc::CreateBuiltinAudioDecoderFactory()); 3518 nullptr, webrtc::CreateBuiltinAudioDecoderFactory());
3517 webrtc::RtcEventLogNullImpl event_log; 3519 webrtc::RtcEventLogNullImpl event_log;
3518 std::unique_ptr<webrtc::Call> call( 3520 std::unique_ptr<webrtc::Call> call(
3519 webrtc::Call::Create(webrtc::Call::Config(&event_log))); 3521 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
3520 cricket::WebRtcVoiceMediaChannel channel(&engine, cricket::MediaConfig(), 3522 cricket::WebRtcVoiceMediaChannel channel(&engine, cricket::MediaConfig(),
3521 cricket::AudioOptions(), call.get()); 3523 cricket::AudioOptions(), call.get());
3522 cricket::AudioRecvParameters parameters; 3524 cricket::AudioRecvParameters parameters;
3523 parameters.codecs = engine.recv_codecs(); 3525 parameters.codecs = engine.recv_codecs();
3524 EXPECT_TRUE(channel.SetRecvParameters(parameters)); 3526 EXPECT_TRUE(channel.SetRecvParameters(parameters));
3525 } 3527 }
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698