Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: webrtc/audio/audio_send_stream.cc

Issue 2431443003: Add a placeholder stat for logging the estimated residual echo likelihood. (Closed)
Patch Set: Fredrik's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/statstypes.cc ('k') | webrtc/audio/audio_send_stream_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 int erl = -100; 229 int erl = -100;
230 int erle = -100; 230 int erle = -100;
231 int dummy1 = 0; 231 int dummy1 = 0;
232 int dummy2 = 0; 232 int dummy2 = 0;
233 error = processing->GetEchoMetrics(erl, erle, dummy1, dummy2); 233 error = processing->GetEchoMetrics(erl, erle, dummy1, dummy2);
234 RTC_DCHECK_EQ(0, error); 234 RTC_DCHECK_EQ(0, error);
235 stats.echo_return_loss = erl; 235 stats.echo_return_loss = erl;
236 stats.echo_return_loss_enhancement = erle; 236 stats.echo_return_loss_enhancement = erle;
237 } 237 }
238 238
239 // TODO(ivoc): Hook this up to the residual echo detector.
240 stats.residual_echo_likelihood = 0.0f;
241
239 internal::AudioState* audio_state = 242 internal::AudioState* audio_state =
240 static_cast<internal::AudioState*>(audio_state_.get()); 243 static_cast<internal::AudioState*>(audio_state_.get());
241 stats.typing_noise_detected = audio_state->typing_noise_detected(); 244 stats.typing_noise_detected = audio_state->typing_noise_detected();
242 245
243 return stats; 246 return stats;
244 } 247 }
245 248
246 void AudioSendStream::SignalNetworkState(NetworkState state) { 249 void AudioSendStream::SignalNetworkState(NetworkState state) {
247 RTC_DCHECK(thread_checker_.CalledOnValidThread()); 250 RTC_DCHECK(thread_checker_.CalledOnValidThread());
248 } 251 }
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 283
281 VoiceEngine* AudioSendStream::voice_engine() const { 284 VoiceEngine* AudioSendStream::voice_engine() const {
282 internal::AudioState* audio_state = 285 internal::AudioState* audio_state =
283 static_cast<internal::AudioState*>(audio_state_.get()); 286 static_cast<internal::AudioState*>(audio_state_.get());
284 VoiceEngine* voice_engine = audio_state->voice_engine(); 287 VoiceEngine* voice_engine = audio_state->voice_engine();
285 RTC_DCHECK(voice_engine); 288 RTC_DCHECK(voice_engine);
286 return voice_engine; 289 return voice_engine;
287 } 290 }
288 } // namespace internal 291 } // namespace internal
289 } // namespace webrtc 292 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/api/statstypes.cc ('k') | webrtc/audio/audio_send_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698