Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame.

Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2402853002/ )

This cl now makes cricket::VideoFrame and cricket::WebRtcVideoFrame aliases for webrtc::VideoFrame.

Reason for revert:
Fixing backwards compatibility issues.

Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9 id:160001 of https://codereview.webrtc.org/2315663002/ )
>
> Reason for revert:
> Breaks compile for Chromium builds:
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/10761
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/18142
>
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no member named 'transport_frame_id' in 'cricket::VideoFrame'
>                  weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
>                                              ~~~~~ ^
> 1 error generated.
>
> Please run chromium trybots as described at https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
>
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org  # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
>
> TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrtc.org,nisse@webrtc.org
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
>
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}

TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrtc.org,kjellander@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
Committed: https://crrev.com/09347858f7b9882cb3ef5677cd534ffddc9d6d6a
Cr-Commit-Position: refs/heads/master@{#14678}

[nisse-webrtc, 2016-10-11 21:30:31]

Created Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame.

[kjellander_webrtc, 2016-10-11 22:52:19]

lgtm. It would be nice with a link to the Chrome update CL in the description.

[tkchin_webrtc, 2016-10-11 23:02:22]

On 2016/10/11 22:52:19, kjellander_webrtc wrote:
> lgtm. It would be nice with a link to the Chrome update CL in the description.

lgtm for objc/

[nisse-webrtc, 2016-10-11 23:40:41]

On 2016/10/11 22:52:19, kjellander_webrtc wrote:
> lgtm. It would be nice with a link to the Chrome update CL in the description.

I probably won't get to updating Crome, and landing this cl, until I'm back at
the STO office; I created this cl mainly to 
not lose track of it. There was also another downstream breakage, some
application expected
that including videoframe.h (the cricket header file) implied inclusion of
base/logging.h. I'm considering 
working around that by just adding that include here.

[pthatcher1, 2016-10-13 21:26:29]

lgtm

[nisse-webrtc, 2016-10-18 08:46:50]

Description was changed from

==========
Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1
of https://codereview.webrtc.org/2402853002/ )

Reason for revert:
Reland after updating Chrome.

Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9
id:160001 of https://codereview.webrtc.org/2315663002/ )
> 
> Reason for revert:
> Breaks compile for Chromium builds:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> 
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no
member named 'transport_frame_id' in 'cricket::VideoFrame'
>                  weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
>                                              ~~~~~ ^
> 1 error generated.
> 
> Please run chromium trybots as described at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
> 
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org  # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
> 
>
TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
> 
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}

TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
==========

to

==========
Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1
of https://codereview.webrtc.org/2402853002/ )

This cl now makes cricket::VideoFrame and cricket::WebRtcVideoFrame aliases for
webrtc::VideoFrame.

Reason for revert:
Fixing backwards compatibility issues.

Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9
id:160001 of https://codereview.webrtc.org/2315663002/ )
> 
> Reason for revert:
> Breaks compile for Chromium builds:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> 
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no
member named 'transport_frame_id' in 'cricket::VideoFrame'
>                  weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
>                                              ~~~~~ ^
> 1 error generated.
> 
> Please run chromium trybots as described at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
> 
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org  # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
> 
>
TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
> 
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}

TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
==========

[nisse-webrtc, 2016-10-18 14:06:11]

I've done some additional testing. Chrome cl 
https://codereview.chromium.org/2430643002/ needs to be landed first.

[nisse-webrtc, 2016-10-19 06:30:32]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-10-19 06:30:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, tkchin@webrtc.org, pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2411953002/#ps300001 (title:
"Fix for windows build.")

[commit-bot: I haz the power, 2016-10-19 06:30:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-19 07:30:32]

Description was changed from

==========
Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1
of https://codereview.webrtc.org/2402853002/ )

This cl now makes cricket::VideoFrame and cricket::WebRtcVideoFrame aliases for
webrtc::VideoFrame.

Reason for revert:
Fixing backwards compatibility issues.

Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9
id:160001 of https://codereview.webrtc.org/2315663002/ )
> 
> Reason for revert:
> Breaks compile for Chromium builds:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> 
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no
member named 'transport_frame_id' in 'cricket::VideoFrame'
>                  weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
>                                              ~~~~~ ^
> 1 error generated.
> 
> Please run chromium trybots as described at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
> 
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org  # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
> 
>
TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
> 
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}

TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
==========

to

==========
Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1
of https://codereview.webrtc.org/2402853002/ )

This cl now makes cricket::VideoFrame and cricket::WebRtcVideoFrame aliases for
webrtc::VideoFrame.

Reason for revert:
Fixing backwards compatibility issues.

Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9
id:160001 of https://codereview.webrtc.org/2315663002/ )
> 
> Reason for revert:
> Breaks compile for Chromium builds:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> 
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no
member named 'transport_frame_id' in 'cricket::VideoFrame'
>                  weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
>                                              ~~~~~ ^
> 1 error generated.
> 
> Please run chromium trybots as described at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
> 
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org  # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
> 
>
TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
> 
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}

TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
==========

[commit-bot: I haz the power, 2016-10-19 07:30:34]

Committed patchset #6 (id:300001)

[commit-bot: I haz the power, 2016-10-19 07:30:37]

Description was changed from

==========
Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1
of https://codereview.webrtc.org/2402853002/ )

This cl now makes cricket::VideoFrame and cricket::WebRtcVideoFrame aliases for
webrtc::VideoFrame.

Reason for revert:
Fixing backwards compatibility issues.

Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9
id:160001 of https://codereview.webrtc.org/2315663002/ )
> 
> Reason for revert:
> Breaks compile for Chromium builds:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> 
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no
member named 'transport_frame_id' in 'cricket::VideoFrame'
>                  weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
>                                              ~~~~~ ^
> 1 error generated.
> 
> Please run chromium trybots as described at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
> 
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org  # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
> 
>
TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
> 
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}

TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682
==========

to

==========
Reland of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #1 id:1
of https://codereview.webrtc.org/2402853002/ )

This cl now makes cricket::VideoFrame and cricket::WebRtcVideoFrame aliases for
webrtc::VideoFrame.

Reason for revert:
Fixing backwards compatibility issues.

Original issue's description:
> Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9
id:160001 of https://codereview.webrtc.org/2315663002/ )
>
> Reason for revert:
> Breaks compile for Chromium builds:
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui...
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
>
> FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o
> ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no
member named 'transport_frame_id' in 'cricket::VideoFrame'
>                  weak_factory_.GetWeakPtr(), frame.transport_frame_id(),
>                                              ~~~~~ ^
> 1 error generated.
>
> Please run chromium trybots as described at
https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding.
>
> Original issue's description:
> > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete
> > all methods but a few constructors. And similarly for the
> > subclass cricket::WebRtcVideoFrame.
> >
> > TBR=tkchin@webrtc.org  # Added an include line
> > BUG=webrtc:5682
> >
> > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968
> > Cr-Commit-Position: refs/heads/master@{#14576}
>
>
TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
> NOTRY=True
> NOPRESUBMIT=True
> BUG=webrtc:5682
>
> Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9
> Cr-Commit-Position: refs/heads/master@{#14583}

TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrt...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5682

Committed: https://crrev.com/09347858f7b9882cb3ef5677cd534ffddc9d6d6a
Cr-Commit-Position: refs/heads/master@{#14678}
==========

[commit-bot: I haz the power, 2016-10-19 07:30:38]

Patchset 6 (id:??) landed as
https://crrev.com/09347858f7b9882cb3ef5677cd534ffddc9d6d6a
Cr-Commit-Position: refs/heads/master@{#14678}