Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 2402853002: Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (Closed)

Created:
4 years, 2 months ago by kjellander_webrtc
Modified:
4 years, 2 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame. (patchset #9 id:160001 of https://codereview.webrtc.org/2315663002/ ) Reason for revert: Breaks compile for Chromium builds: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/10761 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/18142 FAILED: obj/remoting/protocol/protocol/webrtc_video_renderer_adapter.o ../../remoting/protocol/webrtc_video_renderer_adapter.cc:110:52: error: no member named 'transport_frame_id' in 'cricket::VideoFrame' weak_factory_.GetWeakPtr(), frame.transport_frame_id(), ~~~~~ ^ 1 error generated. Please run chromium trybots as described at https://webrtc.org/contributing/#tryjobs-on-chromium-trybots before relanding. Original issue's description: > Make cricket::VideoFrame inherit webrtc::VideoFrame. Delete > all methods but a few constructors. And similarly for the > subclass cricket::WebRtcVideoFrame. > > TBR=tkchin@webrtc.org # Added an include line > BUG=webrtc:5682 > > Committed: https://crrev.com/dda6ec008a0fc8d52e118814fb779032e8931968 > Cr-Commit-Position: refs/heads/master@{#14576} TBR=perkj@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org,tkchin@webrtc.org,nisse@webrtc.org NOTRY=True NOPRESUBMIT=True BUG=webrtc:5682 Committed: https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9 Cr-Commit-Position: refs/heads/master@{#14583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2000 lines, -38 lines) Patch
M webrtc/media/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/media/base/videobroadcaster.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +45 lines, -12 lines 0 comments Download
A webrtc/media/base/videoframe.cc View 1 chunk +171 lines, -0 lines 0 comments Download
A webrtc/media/base/videoframe_unittest.h View 1 chunk +1369 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 2 chunks +89 lines, -15 lines 0 comments Download
A webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 chunk +157 lines, -0 lines 0 comments Download
M webrtc/media/media.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
kjellander_webrtc
Created Revert of Make cricket::VideoFrame inherit webrtc::VideoFrame.
4 years, 2 months ago (2016-10-09 04:40:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2402853002/1
4 years, 2 months ago (2016-10-09 04:45:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9077)
4 years, 2 months ago (2016-10-09 04:55:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2402853002/1
4 years, 2 months ago (2016-10-09 05:21:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-09 05:21:39 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d36dd499c8f253cbcf37364c2a070c2e8c7100e9 Cr-Commit-Position: refs/heads/master@{#14583}
4 years, 2 months ago (2016-10-09 05:21:47 UTC) #13
nisse-webrtc
4 years, 2 months ago (2016-10-11 21:30:31 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2411953002/ by nisse@webrtc.org.

The reason for reverting is: Reland after updating Chrome..

Powered by Google App Engine
This is Rietveld 408576698