Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2406193002: Made the AudioProcessing class a pure interface. (Closed)

Created:
4 years, 2 months ago by peah-webrtc
Modified:
4 years, 2 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

The AudioProcessing class is used as an interface to the functionality in the audio processing module. Therefore, it should be a pure interface. This CL ensures that is the case. BUG=webrtc:6515 Committed: https://crrev.com/73a28ee066d62c238e8c669ab781bdf289b720ee Cr-Commit-Position: refs/heads/master@{#14608}

Patch Set 1 #

Patch Set 2 : Corrected mock of the AudioProcessing interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
peah-webrtc
4 years, 2 months ago (2016-10-11 09:22:38 UTC) #3
the sun
lgtm
4 years, 2 months ago (2016-10-12 08:41:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2406193002/20001
4 years, 2 months ago (2016-10-12 08:55:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 10:01:52 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 10:02:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73a28ee066d62c238e8c669ab781bdf289b720ee
Cr-Commit-Position: refs/heads/master@{#14608}

Powered by Google App Engine
This is Rietveld 408576698