Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 2406193002: Made the AudioProcessing class a pure interface. (Closed)
Patch Set: Corrected mock of the AudioProcessing interface Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/include/audio_processing.h
diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h
index b5d2aa22c0348cd4da2011fb7a67803d80862337..0fdbfd2d75cf48caa50bb8b2f8a86f5e156ee353 100644
--- a/webrtc/modules/audio_processing/include/audio_processing.h
+++ b/webrtc/modules/audio_processing/include/audio_processing.h
@@ -454,14 +454,12 @@ class AudioProcessing {
virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0;
// TODO(ivoc): Remove this function after Chrome stops using it.
- int StartDebugRecording(FILE* handle) {
- return StartDebugRecording(handle, -1);
- }
+ virtual int StartDebugRecording(FILE* handle) = 0;
// Same as above but uses an existing PlatformFile handle. Takes ownership
// of |handle| and closes it at StopDebugRecording().
// TODO(xians): Make this interface pure virtual.
- virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle);
+ virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle) = 0;
// Stops recording debugging information, and closes the file. Recording
// cannot be resumed in the same file (without overwriting it).
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/include/audio_processing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698