Chromium Code Reviews

Side by Side Diff: webrtc/modules/audio_processing/include/audio_processing.h

Issue 2406193002: Made the AudioProcessing class a pure interface. (Closed)
Patch Set: Corrected mock of the AudioProcessing interface Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 436 matching lines...)
447 // <= 0, no limit will be used. 447 // <= 0, no limit will be used.
448 static const size_t kMaxFilenameSize = 1024; 448 static const size_t kMaxFilenameSize = 1024;
449 virtual int StartDebugRecording(const char filename[kMaxFilenameSize], 449 virtual int StartDebugRecording(const char filename[kMaxFilenameSize],
450 int64_t max_log_size_bytes) = 0; 450 int64_t max_log_size_bytes) = 0;
451 451
452 // Same as above but uses an existing file handle. Takes ownership 452 // Same as above but uses an existing file handle. Takes ownership
453 // of |handle| and closes it at StopDebugRecording(). 453 // of |handle| and closes it at StopDebugRecording().
454 virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0; 454 virtual int StartDebugRecording(FILE* handle, int64_t max_log_size_bytes) = 0;
455 455
456 // TODO(ivoc): Remove this function after Chrome stops using it. 456 // TODO(ivoc): Remove this function after Chrome stops using it.
457 int StartDebugRecording(FILE* handle) { 457 virtual int StartDebugRecording(FILE* handle) = 0;
458 return StartDebugRecording(handle, -1);
459 }
460 458
461 // Same as above but uses an existing PlatformFile handle. Takes ownership 459 // Same as above but uses an existing PlatformFile handle. Takes ownership
462 // of |handle| and closes it at StopDebugRecording(). 460 // of |handle| and closes it at StopDebugRecording().
463 // TODO(xians): Make this interface pure virtual. 461 // TODO(xians): Make this interface pure virtual.
464 virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle); 462 virtual int StartDebugRecordingForPlatformFile(rtc::PlatformFile handle) = 0;
465 463
466 // Stops recording debugging information, and closes the file. Recording 464 // Stops recording debugging information, and closes the file. Recording
467 // cannot be resumed in the same file (without overwriting it). 465 // cannot be resumed in the same file (without overwriting it).
468 virtual int StopDebugRecording() = 0; 466 virtual int StopDebugRecording() = 0;
469 467
470 // Use to send UMA histograms at end of a call. Note that all histogram 468 // Use to send UMA histograms at end of a call. Note that all histogram
471 // specific member variables are reset. 469 // specific member variables are reset.
472 virtual void UpdateHistogramsOnCallEnd() = 0; 470 virtual void UpdateHistogramsOnCallEnd() = 0;
473 471
474 // These provide access to the component interfaces and should never return 472 // These provide access to the component interfaces and should never return
(...skipping 525 matching lines...)
1000 // This does not impact the size of frames passed to |ProcessStream()|. 998 // This does not impact the size of frames passed to |ProcessStream()|.
1001 virtual int set_frame_size_ms(int size) = 0; 999 virtual int set_frame_size_ms(int size) = 0;
1002 virtual int frame_size_ms() const = 0; 1000 virtual int frame_size_ms() const = 0;
1003 1001
1004 protected: 1002 protected:
1005 virtual ~VoiceDetection() {} 1003 virtual ~VoiceDetection() {}
1006 }; 1004 };
1007 } // namespace webrtc 1005 } // namespace webrtc
1008 1006
1009 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_INCLUDE_AUDIO_PROCESSING_H_ 1007 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_INCLUDE_AUDIO_PROCESSING_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/include/audio_processing.cc » ('j') | no next file with comments »

Powered by Google App Engine