Cleaning build file for audio network adaptor.

Cleaning build file for audio network adaptor.

BUG=webrtc:6303
Committed: https://crrev.com/0d382efbdcf70e3dc9ed213a56994a89dc266563
Cr-Commit-Position: refs/heads/master@{#14575}

[minyue-webrtc, 2016-10-06 15:54:09]

Description was changed from

==========
Merge branch 'master' into ana_build_clean


aaa


fixing bots


adding missing include


final polish


final polish


fixing


using old struct


repolishing


using factory


on Karl's comments


Merge branch 'ana_10' into ana_1


Merge branch 'master' into ana_10


after rebasing


Merge branch 'ana_10' into ana_1


rebasing


Merge branch 'master' of https://chromium.googlesource.com/external/webrtc into
ana_10


int8_t on enum class


Merge branch 'ana_10' into ana_1


enum->enum class


working now


Merge branch 'ana_10' into ana_1


Updates


not yet finished


Merge branch 'ana_10' into ana_1


removing codec field


improving tests


Merge branch 'master' into ana_10


adding tests


Creating controller manager from config string in audio network adaptor.


some updates


working version


a test added.


Removing a useless ctor in AudioNetworkAdaptorImpl.


needs to add tests


Merge branch 'ana_1_0' into ana_1


Hooking up target audio bitrate to audio network adaptor.


Merge branch 'master' of https://chromium.googlesource.com/external/webrtc into
ana_1


aaa


build


Merge branch 'master' of https://chromium.googlesource.com/external/webrtc into
ana_1


half


to continue


half way


adding contents


Merge branch 'master' of https://chromium.googlesource.com/external/webrtc into
ana_1


adding apis

BUG=
==========

to

==========
Cleaning build file for audio network adaptor.

BUG=webrtc:6303
==========

[minyue-webrtc, 2016-10-06 15:54:09]

minyue@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[minyue-webrtc, 2016-10-06 15:59:18]

Hi Karl,

A small cleaning-up CL. PTAL, thanks!

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (left):

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:117: ":audio_network_adaptor",
audio_coding does not need to depend on audio_network_adaptor directly. Deps
comes from webrtc_opus.

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:712:
rtc_static_library("audio_network_adaptor") {
all other targets uses rtc_static_library since
https://codereview.webrtc.org/2361623004, this is missed because a wrong name to
begin with.

[kwiberg-webrtc, 2016-10-07 12:14:25]

lgtm

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (left):

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:117: ":audio_network_adaptor",
On 2016/10/06 15:59:18, minyue-webrtc wrote:
> audio_coding does not need to depend on audio_network_adaptor directly. Deps
> comes from webrtc_opus.

Nice.

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2399883002/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:712:
rtc_static_library("audio_network_adaptor") {
On 2016/10/06 15:59:18, minyue-webrtc wrote:
> all other targets uses rtc_static_library since
> https://codereview.webrtc.org/2361623004, this is missed because a wrong name
to
> begin with.

Acknowledged.

[minyue-webrtc, 2016-10-07 13:49:16]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-10-07 13:49:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-07 14:59:29]

Description was changed from

==========
Cleaning build file for audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Cleaning build file for audio network adaptor.

BUG=webrtc:6303
==========

[commit-bot: I haz the power, 2016-10-07 14:59:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 14:59:38]

Description was changed from

==========
Cleaning build file for audio network adaptor.

BUG=webrtc:6303
==========

to

==========
Cleaning build file for audio network adaptor.

BUG=webrtc:6303

Committed: https://crrev.com/0d382efbdcf70e3dc9ed213a56994a89dc266563
Cr-Commit-Position: refs/heads/master@{#14575}
==========

[commit-bot: I haz the power, 2016-10-07 14:59:39]

Patchset 1 (id:??) landed as
https://crrev.com/0d382efbdcf70e3dc9ed213a56994a89dc266563
Cr-Commit-Position: refs/heads/master@{#14575}