Cleaning build file for audio network adaptor.

webrtc/modules/audio_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 import("audio_coding.gni")
@@ skipping 96 matching lines @@
   }
 
   if (is_win) {
     cflags = [
       # TODO(kjellander): Bug 261: fix this warning.
       "/wd4373",  # virtual function override.
     ]
   }
 
   deps = audio_coding_deps + [
-           ":audio_network_adaptor",

[minyue-webrtc, 2016/10/06 15:59:18]

audio_coding does not need to depend on audio_network_adaptor directly. Deps
comes from webrtc_opus.

[kwiberg-webrtc, 2016/10/07 12:14:25]

Nice.

            ":neteq",
            ":rent_a_codec",
            "../../logging:rtc_event_log_api",
          ]
   defines = audio_coding_defines
 }
 
 rtc_static_library("audio_decoder_interface") {
   sources = [
     "codecs/audio_decoder.cc",
@@ skipping 575 matching lines @@
     proto_out_dir = "webrtc/modules/audio_coding/audio_network_adaptor"
   }
   proto_library("ana_config_proto") {
     sources = [
       "audio_network_adaptor/config.proto",
     ]
     proto_out_dir = "webrtc/modules/audio_coding/audio_network_adaptor"
   }
 }
 
-source_set("audio_network_adaptor") {
+rtc_static_library("audio_network_adaptor") {

[minyue-webrtc, 2016/10/06 15:59:18]

all other targets uses rtc_static_library since
https://codereview.webrtc.org/2361623004, this is missed because a wrong name to
begin with.

[kwiberg-webrtc, 2016/10/07 12:14:25]

Acknowledged.

   sources = [
     "audio_network_adaptor/audio_network_adaptor.cc",
     "audio_network_adaptor/audio_network_adaptor_impl.cc",
     "audio_network_adaptor/audio_network_adaptor_impl.h",
     "audio_network_adaptor/bitrate_controller.cc",
     "audio_network_adaptor/bitrate_controller.h",
     "audio_network_adaptor/channel_controller.cc",
     "audio_network_adaptor/channel_controller.h",
     "audio_network_adaptor/controller.cc",
     "audio_network_adaptor/controller.h",
     "audio_network_adaptor/controller_manager.cc",
     "audio_network_adaptor/controller_manager.h",
     "audio_network_adaptor/debug_dump_writer.cc",
     "audio_network_adaptor/debug_dump_writer.h",
     "audio_network_adaptor/dtx_controller.cc",
     "audio_network_adaptor/dtx_controller.h",
     "audio_network_adaptor/fec_controller.cc",
     "audio_network_adaptor/fec_controller.h",
     "audio_network_adaptor/frame_length_controller.cc",
     "audio_network_adaptor/frame_length_controller.h",
     "audio_network_adaptor/include/audio_network_adaptor.h",
     "audio_network_adaptor/smoothing_filter.cc",
     "audio_network_adaptor/smoothing_filter.h",
   ]
-  configs += [ "../..:common_config" ]
-  public_configs = [ "../..:common_inherited_config" ]
 
   deps = [
     "../..:webrtc_common",
     "../../system_wrappers",
   ]
 
   if (rtc_enable_protobuf) {
     deps += [
       ":ana_config_proto",
       ":ana_debug_dump_proto",
@@ skipping 871 matching lines @@
       "//testing/gtest",
     ]
 
     if (is_clang) {
       # Suppress warnings from Chrome's Clang plugins.
       # See http://code.google.com/p/webrtc/issues/detail?id=163 for details.
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }